Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to parent.children when module cached #3933

Closed
wants to merge 2 commits into from

Conversation

welefen
Copy link

@welefen welefen commented Nov 20, 2015

No description provided.

@targos targos added the module Issues and PRs related to the module subsystem. label Nov 20, 2015
@rvagg
Copy link
Member

rvagg commented Nov 20, 2015

Can you try and come up with a test for this @welefen? To both demonstrate the problem and prevent regressions. Also, if you do make jslint you'll probably find a couple of objections to your formatting.

@jasnell
Copy link
Member

jasnell commented Nov 20, 2015

also, @welefen , can I ask you to provide a description of the problem and fix being made in the commit log and PR text?

@welefen
Copy link
Author

welefen commented Nov 21, 2015

i will do hot reload in Node.js with require.cache, when base file changed, it will be clear base file cache and which files required base file. but base file only be find in module.children which first required base file.

@jasnell
Copy link
Member

jasnell commented Mar 22, 2016

@welefen ... is this still something you want to pursue? If so, can you add some detail to the commit log per #3933 (comment) and possibly add a test case?

@Jokero
Copy link

Jokero commented Jun 6, 2016

@welefen ping

@jasnell
Copy link
Member

jasnell commented Feb 28, 2017

Closing given the lack of forward progress on this

@jasnell jasnell closed this Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants