Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: fix building with system c-ares on Linux #39739

Closed
wants to merge 2 commits into from
Closed

deps: fix building with system c-ares on Linux #39739

wants to merge 2 commits into from

Commits on Aug 12, 2021

  1. deps: fix building with system c-ares on Linux 

    The change in nodejs#39724 breaks building with system c-ares
(`--shared-cares`):
```
In file included from ../src/cares_wrap.cc:25:
../src/cares_wrap.h:25:11: fatal error: ares_nameser.h: No such file or
directory
   25 | # include <ares_nameser.h>
      |           ^~~~~~~~~~~~~~~~
```

Since `ares_nameser.h` isn't available with a default system c-ares
installation, let's copy it as our private header here.

Tested to build fine on Arch Linux with shared c-ares.
    @felixonmars
    felixonmars committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    aff98a5 View commit details
    Browse the repository at this point in the history

  2. build: ignore cpplint for third-party ares_nameser.h

    @felixonmars
    felixonmars committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    db46439 View commit details
    Browse the repository at this point in the history