Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move util.toUSVString() outside of deprecated group #39840

Closed
wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Aug 22, 2021

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Aug 22, 2021
@lpinca lpinca force-pushed the move/tousvstring-documentation branch from e82c393 to 6737257 Compare August 22, 2021 06:06
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 22, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 22, 2021
@github-actions
Copy link
Contributor

Landed in 82ae00c...0073831

@github-actions github-actions bot closed this Aug 22, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 22, 2021
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849

PR-URL: #39840
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@lpinca lpinca deleted the move/tousvstring-documentation branch August 22, 2021 10:51
@Trott
Copy link
Member

Trott commented Aug 22, 2021

This also happened to fix a markdown lint error that snuck in while the linter was broken. 👍

targos pushed a commit that referenced this pull request Aug 23, 2021
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849

PR-URL: #39840
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Sep 4, 2021
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849

PR-URL: #39840
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants