Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.8.0 release proposal #39875

Merged
merged 33 commits into from
Aug 25, 2021
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
7a25bf3
doc: add himadriganguly as a triager
himadriganguly Aug 13, 2021
a387600
doc: add example of self-reference in scoped packages
piranna Mar 6, 2021
c34e253
tools: update markdown lint dependencies
Trott Aug 15, 2021
2b02f74
doc: fix lint errors in packages.md
Trott Aug 17, 2021
3041d57
doc: fix malformed changelog entries
Trott Aug 13, 2021
3f284cf
build: add option to hide console window
zcbenz Aug 9, 2021
8460a32
doc: deprecate using non-boolean values in the `verbatim` option
aduh95 Jun 2, 2021
2e90b10
doc: deprecate type coercion for `dns.lookup` options
aduh95 Jun 11, 2021
a7a217b
repl: fix tla function hoisting
DonJayamanne Aug 15, 2021
8fa3850
policy: canonicalize before resolving specifiers
bmeck Mar 22, 2021
9dc0c91
tools: update rollup to latest version in markdown linter
Trott Aug 18, 2021
158d446
meta: add gyp as owner of gyp files and tools/gyp
mmarchini Aug 20, 2021
0918ea0
src: add a constructor overload for CallbackScope
RaisinTen Aug 15, 2021
a704c9d
src: call overload ctor from the original ctor
RaisinTen Aug 17, 2021
01093b0
tools: update markdown linter dependencies and move to ESM
aduh95 Aug 18, 2021
d1900f4
fs: combine require() and destructure
cjihrig Aug 19, 2021
79079ea
tools: fix markdown linting
Trott Aug 21, 2021
6640037
util: expose toUSVString
ronag Aug 19, 2021
208305f
doc: move util.toUSVString() outside of deprecated group
lpinca Aug 22, 2021
d82ee96
tools: update gyp-next to v0.9.5
gengjiawen Aug 20, 2021
3a8399e
src: return Maybe<bool> from InitializeContextRuntime()
RaisinTen Aug 7, 2021
af7047a
stream: add isDisturbed helper
ronag Aug 2, 2021
a6d50a1
stream: duplexify
ronag Jul 25, 2021
cce95c4
deps: upgrade npm to 7.21.0
MylesBorins Aug 23, 2021
c02165d
doc: update instructions for cc
mhdawson Aug 5, 2021
a01e3ab
deps: V8: cherry-pick 00bb1a77c03e
RaisinTen Aug 21, 2021
8c50d16
doc: improve description of the triagers team
targos Aug 21, 2021
c968372
build: add authors.yml
bnb Aug 20, 2021
254810a
doc: add duplicate CVE check in sec. release doc
danbev Aug 23, 2021
90bf247
build: fix update authors commit
Mesteery Aug 24, 2021
d33f897
tools: use find-inactive-collaborators to modify README.md
Trott Aug 21, 2021
f98311a
tools: update workflow to open a pull request
Trott Aug 21, 2021
93553dc
2021-08-25, Version 16.8.0 (Current)
targos Aug 25, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: call overload ctor from the original ctor
Call the new constructor overload from the original constructor to
reduce code duplication.

Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: #39768
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
  • Loading branch information
RaisinTen authored and targos committed Aug 22, 2021
commit a704c9dfcef5762f2f28dc64fbef10629df1502c
9 changes: 2 additions & 7 deletions src/api/callback.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,8 @@ using v8::Value;

CallbackScope::CallbackScope(Isolate* isolate,
Local<Object> object,
async_context asyncContext)
: private_(new InternalCallbackScope(Environment::GetCurrent(isolate),
object,
asyncContext)),
try_catch_(isolate) {
try_catch_.SetVerbose(true);
}
async_context async_context)
: CallbackScope(Environment::GetCurrent(isolate), object, async_context) {}

CallbackScope::CallbackScope(Environment* env,
Local<Object> object,
Expand Down