Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16.x] doc: remove {C,Dec}ompressionStream documentation #39899

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Aug 26, 2021

Documentation for CompressionStream and DecompressionStream was
erroneously added in f57a0e4d8b.

Fixes: #39895

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v16.x labels Aug 26, 2021
@lpinca lpinca force-pushed the remove/compression-decompression-stream-documentation branch from 87bffb2 to b86cfe6 Compare August 26, 2021 13:17
@lpinca
Copy link
Member Author

lpinca commented Aug 26, 2021

I'm not sure if it's better to land this or wait for 09ad64d to be backported.

lpinca added a commit to lpinca/node that referenced this pull request Aug 26, 2021
Documentation for `CompressionStream` and `DecompressionStream` was
erroneously added in nodejs@f57a0e4d8b
and released in version 16.7.0.

Reset the added: version to REPLACEME.

Refs: nodejs#39348
Refs: nodejs#39899
Documentation for `CompressionStream` and `DecompressionStream` was
erroneously added in nodejs@f57a0e4d8b.

Fixes: nodejs#39895
@lpinca lpinca force-pushed the remove/compression-decompression-stream-documentation branch from b86cfe6 to 8715e14 Compare August 26, 2021 13:37
@lpinca lpinca changed the title [v16.x] doc: remove {C,Deco}ompressionStream documentation [v16.x] doc: remove {C,Dec}ompressionStream documentation Aug 26, 2021
lpinca added a commit to lpinca/node that referenced this pull request Aug 26, 2021
Documentation for `CompressionStream` and `DecompressionStream` was
erroneously added in nodejs@f57a0e4d8b
and released in version 16.7.0.

Reset the `added:` version to `REPLACEME`.

Refs: nodejs#39348
Refs: nodejs#39899
jasnell pushed a commit that referenced this pull request Aug 28, 2021
Documentation for `CompressionStream` and `DecompressionStream` was
erroneously added in f57a0e4d8b
and released in version 16.7.0.

Reset the `added:` version to `REPLACEME`.

Refs: #39348
Refs: #39899

PR-URL: #39901
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@lpinca
Copy link
Member Author

lpinca commented Aug 29, 2021

I'm closing this as per #39899 (comment).

@lpinca lpinca closed this Aug 29, 2021
@lpinca lpinca deleted the remove/compression-decompression-stream-documentation branch August 29, 2021 19:25
@targos
Copy link
Member

targos commented Aug 30, 2021

Do you know of anyone is working on a backport?

@lpinca
Copy link
Member Author

lpinca commented Aug 30, 2021

@targos no, I will reopen.

@lpinca lpinca restored the remove/compression-decompression-stream-documentation branch August 30, 2021 05:40
@lpinca lpinca reopened this Aug 30, 2021
targos pushed a commit that referenced this pull request Sep 6, 2021
Documentation for `CompressionStream` and `DecompressionStream` was
erroneously added in f57a0e4d8b.

Fixes: #39895

PR-URL: #39899
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member

targos commented Sep 6, 2021

Landed in 9e782eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants