Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do not run test-corepack-yarn-install with no internet #40090

Closed
wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 12, 2021

It looks like this test requires internet access to succeed, moving it to the relevant folder. I've also added a line to dump stdout when the test fails as it contains relevant info to understand the failure.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 12, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Sep 12, 2021
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if CI runs internet tests.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 16, 2021
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/40090
✔  Done loading data for nodejs/node/pull/40090
----------------------------------- PR info ------------------------------------
Title      test: do not run `test-corepack-yarn-install` with no internet (#40090)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:yarn-test-internet -> nodejs:master
Labels     test, author ready
Commits    1
 - test: do not run `test-corepack-yarn-install` with no internet
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/40090
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40090
Reviewed-By: Luigi Pinca 
Reviewed-By: Tobias Nießen 
Reviewed-By: Michaël Zasso 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 12 Sep 2021 14:28:37 GMT
   ✔  Approvals: 5
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40090#pullrequestreview-752188232
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-752225082
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-752385388
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-752782487
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40090#pullrequestreview-754083383
   ✔  Last GitHub Actions successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1243446870

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 16, 2021
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 16, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2021
@github-actions
Copy link
Contributor

Landed in 2b080cb...3101c09

@github-actions github-actions bot closed this Sep 18, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 18, 2021
PR-URL: #40090
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@aduh95 aduh95 deleted the yarn-test-internet branch September 18, 2021 22:21
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #40090
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #40090
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants