Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: check for duplicates in new AUTHORS entries #40264

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 30, 2021

When the GitHub Action adds new entries to the AUTHORS file, have it
also flag new entries that might be duplicates.

When the GitHub Action adds new entries to the AUTHORS file, have it
also flag new entries that might be duplicates.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 30, 2021
@Trott
Copy link
Member Author

Trott commented Sep 30, 2021

I imagine the code here can be simplified a bit, or at least organized a bit better (with more clear comments). Like, the cut sort uniq sort grep perl is fine for shell experimentation but we can probably make that more elegant. Nonetheless, I do think it's sufficiently coherent for others to review.

@Trott Trott marked this pull request as ready for review September 30, 2021 07:46
@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 3, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2021

Landed in 1811396...2a3a9b8

@github-actions github-actions bot closed this Oct 3, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 3, 2021
When the GitHub Action adds new entries to the AUTHORS file, have it
also flag new entries that might be duplicates.

PR-URL: #40264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott Trott deleted the duplicates branch October 3, 2021 20:50
targos pushed a commit that referenced this pull request Oct 4, 2021
When the GitHub Action adds new entries to the AUTHORS file, have it
also flag new entries that might be duplicates.

PR-URL: #40264
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants