Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update wpt.fyi used daily checkout ref #46730

Closed
wants to merge 1 commit into from
Closed

tools: update wpt.fyi used daily checkout ref #46730

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Feb 19, 2023 •
edited
Loading

For some reason actions/checkout does not fetch the actual branch at a given time consistently. Let's try with the gh API.

$ echo "WPT_DAILY_REF=$(gh api /repos/web-platform-tests/wpt/branches/epochs/daily --jq '.commit.sha')"
WPT_DAILY_REF=96ef5777e50f7ed8f54b91525002d6708fc097d7

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 19, 2023
@panva panva added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 19, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@panva
Copy link
Member Author

panva commented Feb 19, 2023

🙏 fast-track PRs that do not need to wait for 48 hours to land. above so that the jobs start with consistent wpt ref.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 19, 2023
@nodejs-github-bot

This comment was marked as resolved.

Sign in to view
panva added a commit that referenced this pull request Feb 19, 2023
@panva
tools: update wpt.fyi used daily checkout ref
225c578 
PR-URL: #46730
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva
Copy link
Member Author

panva commented Feb 19, 2023

Landed in 225c578

@panva panva closed this Feb 19, 2023
@panva panva deleted the wpt-daily-update-ref branch February 19, 2023 18:59
mertcanaltin pushed a commit to mertcanaltin/node that referenced this pull request Feb 19, 2023
@panva @mertcanaltin
tools: update wpt.fyi used daily checkout ref
82f684d 
PR-URL: nodejs#46730
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Mar 13, 2023
@panva @targos
tools: update wpt.fyi used daily checkout ref
617b5b1 
PR-URL: #46730
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
@danielleadams danielleadams added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @anonrig @aduh95 @danielleadams