Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explaining that vm.SourceTextModule() is able to evaluate in current … #47295

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

axkibe
Copy link
Contributor

@axkibe axkibe commented Mar 29, 2023

Covers my feature request that is already implemented, just not documented.

Fixes: #47280

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Mar 29, 2023
Copy link
Member

@debadree25 debadree25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for your contribution, could you just rebase and update the commit message to adhere to the guidelines https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

Thank You!

Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: nodejs#47280
@axkibe
Copy link
Contributor Author

axkibe commented Mar 29, 2023

I changed the message by force pushing to my fork if thats okay.

@debadree25
Copy link
Member

That is not a problem!

@debadree25
Copy link
Member

Also cc @nodejs/vm

@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2023
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit b74b9dd into nodejs:main Mar 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in b74b9dd

RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: #47280
PR-URL: #47295
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: #47280
PR-URL: #47295
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: #47280
PR-URL: #47295
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: #47280
PR-URL: #47295
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Explaining that vm.SourceTextModule() is able to evaluate in current
context if non is given

Fixes: #47280
PR-URL: #47295
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running vm.SourceTextModule in thisContext
6 participants