Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve permission.has description #47875

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented May 5, 2023

This fixes the function description and adds missing available scopes.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

This fixes the function description and adds missing available scopes.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 5, 2023
@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2023
doc/api/process.md Show resolved Hide resolved
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9f39a9d into nodejs:main May 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 9f39a9d

@daeyeon daeyeon deleted the main.fix/doc/permission-230505.Fri.a615 branch May 9, 2023 05:40
targos pushed a commit that referenced this pull request May 12, 2023
This fixes the function description and adds missing available scopes.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #47875
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants