Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing deprecated blocks to cluster #47981

Merged

Conversation

tniessen
Copy link
Member

I believe that these are required so that the respective APIs are marked as deprecated in the table of contents.

I believe that these are required so that the respective APIs are
marked as deprecated in the table of contents.
@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels May 12, 2023
@tniessen tniessen added the deprecations Issues and PRs related to deprecations. label May 12, 2023
@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 13, 2023
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2023
deokjinkim added a commit to deokjinkim/node that referenced this pull request May 14, 2023
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark and test.

Refs: nodejs#47981
deokjinkim added a commit to deokjinkim/node that referenced this pull request May 14, 2023
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: nodejs#47981
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit c9ec72d into nodejs:main May 14, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in c9ec72d

targos pushed a commit that referenced this pull request May 15, 2023
I believe that these are required so that the respective APIs are
marked as deprecated in the table of contents.

PR-URL: #47981
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request May 17, 2023
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: #47981
PR-URL: #48002
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen
Copy link
Member Author

I believe that these are required so that the respective APIs are marked as deprecated in the table of contents.

This turned out to be true :)

targos pushed a commit that referenced this pull request May 30, 2023
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: #47981
PR-URL: #48002
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
I believe that these are required so that the respective APIs are
marked as deprecated in the table of contents.

PR-URL: #47981
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: #47981
PR-URL: #48002
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
I believe that these are required so that the respective APIs are
marked as deprecated in the table of contents.

PR-URL: nodejs#47981
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
`cluster.isMaster` was deprecated. So need to use `cluster.isPrimary`
for benchmark.

Refs: nodejs#47981
PR-URL: nodejs#48002
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cluster Issues and PRs related to the cluster subsystem. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants