Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: run license-builder #48336

Merged
merged 1 commit into from
Jun 7, 2023
Merged

doc: run license-builder #48336

merged 1 commit into from
Jun 7, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 5, 2023

License is likely out of date. This is an automatically generated PR by the license-builder.yml GitHub Action, which runs license-builder.sh and submits a new PR or updates an existing PR.

@github-actions github-actions bot added the meta Issues and PRs related to the general management of the project. label Jun 5, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@aduh95
Copy link
Contributor

aduh95 commented Jun 5, 2023

Pinging @fasenderos since they are the one who drove the zlib upgrade changes, and the diff looks a bit weird.

@fasenderos
Copy link
Contributor

@aduh95 I'll take a look

@fasenderos
Copy link
Contributor

The changes of this PR reflect the Chromium's copy of zlib that we use (we don't use the official zlib library):
https://chromium.googlesource.com/chromium/src/+/refs/heads/main/third_party/zlib/zlib.h#2

@targos
Copy link
Member

targos commented Jun 6, 2023

More specifically, the license header was changed in https://chromium.googlesource.com/chromium/src/+/f103edb8dc89fd780cd374ca34707617f49d0303%5E%21/#F10

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM defintely hard to line up with what is obvious from the contents under deps but seem to be the right value from the patch @targos linked to.

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking it @fasenderos @targos. LGTM.

@Mesteery Mesteery added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit f100732 into main Jun 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in f100732

@nodejs-github-bot nodejs-github-bot deleted the actions/license-builder branch June 7, 2023 00:29
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
PR-URL: #48336
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48336
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
PR-URL: nodejs#48336
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
PR-URL: #48336
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants