-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
48198 node api external strings #48339
Closed
gabrielschulhof
wants to merge
31
commits into
nodejs:main
from
gabrielschulhof:48198-node-api-external-strings
+713
−176
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
bd8045b
node-api: unify string creation
gabrielschulhof 50a2109
node-api: add string creation benchmark
gabrielschulhof 1364872
node-api: implement external strings
gabrielschulhof a9e24b9
add test
gabrielschulhof e1127d1
rename to node_api_*
gabrielschulhof 953304c
put back build type
gabrielschulhof 09f7cdf
make linter work
gabrielschulhof 902cb33
rename as requested
gabrielschulhof 754864e
use std::basic_string_view to calc length in case of NAPI_AUTO_LENGTH
gabrielschulhof 95a9971
test for auto-length
gabrielschulhof b4f383b
format
gabrielschulhof 05317ac
correct length
gabrielschulhof 20ab0fb
doc
gabrielschulhof ca4c08c
use right length indicator
gabrielschulhof 5de34d4
final adjustment
gabrielschulhof 64f2498
Apply suggestions from code review
gabrielschulhof cb9d95a
Apply suggestions from code review
gabrielschulhof ed83494
remove utf8
gabrielschulhof e063901
handle the case where we copy the string
gabrielschulhof 4ff5e53
implement the non-copying case
gabrielschulhof 402c93e
Unify the two external cases
gabrielschulhof 32a5600
factor out tracking
gabrielschulhof 0b72009
document
gabrielschulhof 50dfa5d
debug ctor dtor
gabrielschulhof 3a96b04
typo
gabrielschulhof caccb8e
Apply suggestions from code review
gabrielschulhof 5c11c81
Apply suggestions from code review
gabrielschulhof b651fca
use common distructor
gabrielschulhof 668fd4d
format
gabrielschulhof c721439
Apply suggestions from code review
gabrielschulhof 7f67a2f
md lint
gabrielschulhof File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rename to node_api_*
- Loading branch information
commit e1127d16ab7c6eb9384cf6d23e9a79490d5330da
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check with Electron if this is needed for strings.