Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: pass syscall on fs.readFileSync fail operation #48815

Merged
merged 1 commit into from
Jul 17, 2023
Merged

src: pass syscall on fs.readFileSync fail operation #48815

merged 1 commit into from
Jul 17, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jul 17, 2023

This fixes v20.5.0 release.

Ref: #48761 (comment)

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jul 17, 2023
@anonrig anonrig mentioned this pull request Jul 17, 2023
Merged
@richardlau
Copy link
Member

Should we add a test for this?

@anonrig
Copy link
Member Author

anonrig commented Jul 17, 2023

Should we add a test for this?

I'm not really sure. The only way to test this outcome is through a carefully written regexp (just like in tape repository). I prefer to add an assertion where syscall exists and is a string, but that might be a breaking change as well.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52814/

@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 17, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 17, 2023
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit 339eb10 into nodejs:main Jul 17, 2023
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 339eb10

juanarbol pushed a commit that referenced this pull request Jul 17, 2023
@anonrig @juanarbol
src: pass syscall on fs.readFileSync fail operation
227e6bd 
PR-URL: #48815
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@anonrig
src: pass syscall on fs.readFileSync fail operation
53db082 
PR-URL: nodejs#48815
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@anonrig
src: pass syscall on fs.readFileSync fail operation
1d93e53 
PR-URL: nodejs#48815
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
src: pass syscall on fs.readFileSync fail operation
e86a485 
PR-URL: nodejs#48815
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
src: pass syscall on fs.readFileSync fail operation
739d382 
PR-URL: nodejs#48815
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@benjamingr benjamingr benjamingr approved these changes

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anonrig @richardlau @nodejs-github-bot @ljharb @benjamingr @debadree25