[v18.x] Revert "url: drop ICU requirement for parsing hostnames"

doc/api/url.md

@@ -1034,6 +1034,9 @@ added:
   - v7.4.0
   - v6.13.0
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/48869
+    description: ICU requirement is back.
   - version: v18.17.0
     pr-url: https://github.com/nodejs/node/pull/47339
     description: ICU requirement is removed.
@@ -1047,6 +1050,9 @@ invalid domain, the empty string is returned.
 
 It performs the inverse operation to [`url.domainToUnicode()`][].
 
+This feature is only available if the `node` executable was compiled with
+[ICU][] enabled. If not, the domain names are passed through unchanged.
+
 ```mjs
 import url from 'node:url';
 
@@ -1076,6 +1082,9 @@ added:
   - v7.4.0
   - v6.13.0
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/48869
+    description: ICU requirement is back.
   - version: v18.17.0
     pr-url: https://github.com/nodejs/node/pull/47339
     description: ICU requirement is removed.
@@ -1089,6 +1098,9 @@ domain, the empty string is returned.
 
 It performs the inverse operation to [`url.domainToASCII()`][].
 
+This feature is only available if the `node` executable was compiled with
+[ICU][] enabled. If not, the domain names are passed through unchanged.
+
 ```mjs
 import url from 'node:url';
 
@@ -1731,6 +1743,7 @@ console.log(myURL.origin);
 // Prints https://xn--1xa.example.com
 ```
 
+[ICU]: intl.md#options-for-building-nodejs
 [Punycode]: https://tools.ietf.org/html/rfc5891#section-4.4
 [WHATWG URL]: #the-whatwg-url-api
 [WHATWG URL Standard]: https://url.spec.whatwg.org/

lib/internal/idna.js

@@ -1,4 +1,9 @@
 'use strict';
 
-const { domainToASCII, domainToUnicode } = require('internal/url');
-module.exports = { toASCII: domainToASCII, toUnicode: domainToUnicode };
+if (internalBinding('config').hasIntl) {
+  const { toASCII, toUnicode } = internalBinding('icu');
+  module.exports = { toASCII, toUnicode };
+} else {
+  const { domainToASCII, domainToUnicode } = require('internal/url');
+  module.exports = { toASCII: domainToASCII, toUnicode: domainToUnicode };
+}

test/benchmark/test-benchmark-url.js

@@ -1,6 +1,18 @@
 'use strict';
 
-require('../common');
+const common = require('../common');
+
+// TODO(@anonrig): Remove this check when Ada removes ICU requirement.
+if (!common.hasIntl) {
+  // A handful of the benchmarks fail when ICU is not included.
+  // ICU is responsible for ignoring certain inputs from the hostname
+  // and without it, it is not possible to validate the correctness of the input.
+  // DomainToASCII method in Unicode specification states which characters are
+  // ignored and/or remapped. Doing this outside of the scope of DomainToASCII,
+  // would be a violation of the WHATWG URL specification.
+  // Please look into: https://unicode.org/reports/tr46/#ProcessingStepMap
+  common.skip('missing Intl');
+}
 
 const runBenchmark = require('../common/benchmark');