Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] fs: add a fast-path for readFileSync utf-8 #49693

Open
wants to merge 6 commits into
base: v18.x-staging
Choose a base branch
from
Open

[v18.x backport] fs: add a fast-path for readFileSync utf-8 #49693

wants to merge 6 commits into from
+109 −6

Conversation

H4ad
Copy link
Member

@H4ad H4ad commented Sep 18, 2023

Backport of #48658

cc @anonrig

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Sep 18, 2023
@targos
Copy link
Member

targos commented Nov 27, 2023

Hey, I'm sorry but a lot of commit landed on the staging branch since you opened this backport and now it has conflicts.

@H4ad H4ad requested a review from targos December 2, 2023 02:45
@richardlau
Copy link
Member

richardlau commented Jan 12, 2024 •
edited
Loading

@nodejs/lts / @nodejs/releasers Now that Node.js 18 is in maintenance I think the risks of this backport PR outweigh potential benefits. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@H4ad @nodejs-github-bot @targos @richardlau @anonrig