stream: use bitmap in readable state #49745

benjamingr · 2023-09-21T10:36:55Z

cc @ronag @anonrig this should save (worst case) 17 bytes per stream

nodejs-github-bot · 2023-09-21T10:37:00Z

Review requested:

@nodejs/streams

nodejs-github-bot · 2023-09-21T10:52:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54115/

benjamingr · 2023-09-21T10:57:37Z

This isn't quite right

H4ad · 2023-09-21T11:03:16Z

lib/internal/streams/readable.js

+function makeBitMapDescriptor(bit) {
+  return {
+    enumerable: true,
+    get() { return (this.flags & bit) !== 0; },
+    set(value) {
+      if (value) this.flags |= bit;
+      else this.flags &= ~bit;
+    },
+  };
+}


You save some booleans but now you need more memory to store these functions and a more complicated property descriptor.

I think this will use more memory than the older version

@H4ad ideally we wouldn't need the functions but note these functions are stored once per all streams vs. once per stream on the prototype.

My next step is to diff with the systems analyzer

The functions are on the prototype so they don't take extra memory. But I don't know how well V8 will inline these calls. Needs a benchmark run.

Ideally I wouldn't want to use these functions and would prefer a static which is more obviously inlinable

benjamingr · 2023-09-21T11:18:52Z

The getters approach doesn't appear to be too V8 friendly, I'll keep open and go over it with Raz and Yagiz (both expressed interest), Robert you're obviously invited (Vinicius too!).

(Moving it from getters to a static function seems to work better, I also didn't benchmark properly, I'll trigger a bench CI just in case)

benjamingr · 2023-09-21T12:33:22Z

It looks like this saves ±40% of the size of ReadableState

after:

before:

benjamingr · 2023-09-21T12:49:49Z

Let's see, I suspect to see a regression (not a big one) in perf given the getters but the analyzer seems to think it's optimized from my understanding the IR generated does look slightly slower so let's see.

https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1400/

lib/internal/streams/readable.js

anonrig · 2023-09-21T16:13:59Z

lib/internal/streams/readable.js

  // Object stream flag. Used to make read(n) ignore n and to
  // make all the buffer merging and length checks go away.
-  this.objectMode = !!(options && options.objectMode);
+  if (options && options.objectMode) this.state |= kObjectMode;


Suggested change

if (options && options.objectMode) this.state |= kObjectMode;

if (options?.objectMode) this.state |= kObjectMode;

I thought that was slower so I followed the pattern, do you know which of the following is faster?

if (options && options.objectMode) this.state |= kObjectMode; if (options?.objectMode) this.state |= kObjectMode; this.state |= kObjectMode & +options?.objectMode;

ronag

There are more stuff you could add to the state.

benjamingr · 2023-09-21T16:52:29Z

There are more stuff you could add to the state.

Way more and more usages and we can fold the length into it if it's reasonably small this is a first attempt/poc

benjamingr · 2023-09-21T16:54:06Z

Looks like a 15% improvement for creation and destruction so very nice, and also I broke something :D I'll run CI to quickly find what.

18:09:08                                                 confidence improvement accuracy (*)   (**)  (***)
18:09:08 streams/creation.js kind='duplex' n=50000000           ***      4.31 %       ±0.94% ±1.25% ±1.63%
18:09:08 streams/creation.js kind='readable' n=50000000         ***     15.30 %       ±1.28% ±1.70% ±2.23%
18:09:08 streams/creation.js kind='transform' n=50000000        ***     13.81 %       ±3.04% ±4.05% ±5.27%
18:09:08 streams/creation.js kind='writable' n=50000000         ***      3.92 %       ±1.08% ±1.44% ±1.87%
18:09:08 streams/destroy.js kind='duplex' n=1000000             ***      7.50 %       ±1.56% ±2.08% ±2.71%
18:09:08 streams/destroy.js kind='readable' n=1000000           ***     15.14 %       ±2.59% ±3.45% ±4.49%
18:09:08 streams/destroy.js kind='transform' n=1000000          ***      6.66 %       ±1.76% ±2.35% ±3.06%
18:09:08 streams/destroy.js kind='writable' n=1000000                    1.08 %       ±2.79% ±3.71% ±4.83%
18:09:08 streams/pipe-object-mode.js n=5000000                   NA       NaN %           NA     NA     NA

benjamingr · 2023-09-21T16:56:42Z

@lpinca what breakage potential does this have? I don't disagree with semver-major but I wanna understand why since this only changes the internals (under _readableState) and even there I kept getters and setters for backwards compatibility.

lpinca · 2023-09-21T16:57:05Z

This would break some userland modules. ws is one of them. We use _readableState.xxx and _writableState.xxx in the code base. We still support old versions of Node.js where getters are not available.

lpinca · 2023-09-21T17:03:50Z

We could check for the bitmap first and then fallback to use the properties if it is not available. It would be a performance hit but probably insignificant.

benjamingr · 2023-09-21T17:08:03Z

This would break some userland modules. ws is one of them. We use _readableState.xxx and _writableState.xxx in the codebase. We still support old versions of Node.js where getters are not available.

You support versions of Node.js before 0.10 (when getters were added)? (Not a jab, I'm pretty sure bluebird still supports 0.8 for... reasons)

nodejs-github-bot · 2023-09-24T09:05:59Z

Landed in e2245dd

PR-URL: #49745 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Notable changes: doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49683 * promote fetch/webstreams from experimental to stable (Steven) #45684 * deprecate `util.toUSVString` (Yagiz Nizipli) #49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) #49647 esm: * set all hooks as release candidate (Geoffrey Booth) #49597 stream: * use bitmap in writable state (Raz Luvaton) #49834 * use bitmap in readable state (Benjamin Gruenbaum) #49745 * improve webstream readable async iterator performance (Raz Luvaton) #49662 PR-URL: TODO

Notable changes: doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49683 * promote fetch/webstreams from experimental to stable (Steven) #45684 * deprecate `util.toUSVString` (Yagiz Nizipli) #49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) #49647 esm: * set all hooks as release candidate (Geoffrey Booth) #49597 stream: * use bitmap in writable state (Raz Luvaton) #49834 * use bitmap in readable state (Benjamin Gruenbaum) #49745 * improve webstream readable async iterator performance (Raz Luvaton) #49662 PR-URL: #49917

Notable changes: doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49683 * deprecate `util.toUSVString` (Yagiz Nizipli) #49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) #49647 esm: * set all hooks as release candidate (Geoffrey Booth) #49597 src: * (SEMVER-MINOR) allow embedders to override NODE_MODULE_VERSION (Cheng Zhao) #49279 stream: * use bitmap in writable state (Raz Luvaton) #49834 * use bitmap in readable state (Benjamin Gruenbaum) #49745 * improve webstream readable async iterator performance (Raz Luvaton) #49662 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) #49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) #49614 PR-URL: TODO

Notable changes: deps: * add v8::Object::SetInternalFieldForNodeCore() (Joyee Cheung) #49874 doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #49683 * deprecate `util.toUSVString` (Yagiz Nizipli) #49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) #49647 esm: * set all hooks as release candidate (Geoffrey Booth) #49597 module: * fix the leak in SourceTextModule and ContextifySript (Joyee Cheung) #48510 * fix leak of vm.SyntheticModule (Joyee Cheung) #48510 * use symbol in WeakMap to manage host defined options (Joyee Cheung) #48510 src: * (SEMVER-MINOR) allow embedders to override NODE_MODULE_VERSION (Cheng Zhao) #49279 stream: * use bitmap in writable state (Raz Luvaton) #49834 * use bitmap in readable state (Benjamin Gruenbaum) #49745 * improve webstream readable async iterator performance (Raz Luvaton) #49662 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) #49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) #49614 PR-URL: #49932

PR-URL: nodejs#49745 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Notable changes: deps: * add v8::Object::SetInternalFieldForNodeCore() (Joyee Cheung) nodejs#49874 doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) nodejs#49683 * deprecate `util.toUSVString` (Yagiz Nizipli) nodejs#49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) nodejs#49647 esm: * set all hooks as release candidate (Geoffrey Booth) nodejs#49597 module: * fix the leak in SourceTextModule and ContextifySript (Joyee Cheung) nodejs#48510 * fix leak of vm.SyntheticModule (Joyee Cheung) nodejs#48510 * use symbol in WeakMap to manage host defined options (Joyee Cheung) nodejs#48510 src: * (SEMVER-MINOR) allow embedders to override NODE_MODULE_VERSION (Cheng Zhao) nodejs#49279 stream: * use bitmap in writable state (Raz Luvaton) nodejs#49834 * use bitmap in readable state (Benjamin Gruenbaum) nodejs#49745 * improve webstream readable async iterator performance (Raz Luvaton) nodejs#49662 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) nodejs#49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) nodejs#49614 PR-URL: nodejs#49932

PR-URL: #49745 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908 * (SEMVER-MINOR) upgrade npm to 10.0.0 (npm team) #49423 doc: * add new TSC members (Michael Dawson) #48841 * move and rename loaders section (Geoffrey Booth) #49261 esm: * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * unflag import.meta.resolve (Guy Bedford) #49028 * move hook execution to separate thread (Jacob Smith) #44710 * leverage loaders when resolving subsequent loaders (Maël Nison) #43772 lib: * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391 * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger) #44943 src: * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan) #45629 stream: * use bitmap in readable state (Benjamin Gruenbaum) #49745 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) #49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) #49614 * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975 * (SEMVER-MINOR) add shards support (Raz Luvaton) #48639 * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141 wasi: * (SEMVER-MINOR) updates required for latest uvwasi version (Michael Dawson) #49908 PR-URL: TODO

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908 * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team) #50531 doc: * move and rename loaders section (Geoffrey Booth) #49261 esm: * use import attributes instead of import assertions (Antoine du Hamel) #50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869 * unflag import.meta.resolve (Guy Bedford) #49028 * move hook execution to separate thread (Jacob Smith) #44710 * leverage loaders when resolving subsequent loaders (Maël Nison) #43772 lib: * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) #46391 * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger) #44943 src: * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan) #45629 stream: * use bitmap in readable state (Benjamin Gruenbaum) #49745 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) #49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) #49614 * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975 * (SEMVER-MINOR) add shards support (Raz Luvaton) #48639 * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) #47775 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) #45190 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141 PR-URL: #50953

Notable changes: deps: * add v8::Object::SetInternalFieldForNodeCore() (Joyee Cheung) nodejs#49874 doc: * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) nodejs#49683 * deprecate `util.toUSVString` (Yagiz Nizipli) nodejs#49725 * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) nodejs#49647 esm: * set all hooks as release candidate (Geoffrey Booth) nodejs#49597 module: * fix the leak in SourceTextModule and ContextifySript (Joyee Cheung) nodejs#48510 * fix leak of vm.SyntheticModule (Joyee Cheung) nodejs#48510 * use symbol in WeakMap to manage host defined options (Joyee Cheung) nodejs#48510 src: * (SEMVER-MINOR) allow embedders to override NODE_MODULE_VERSION (Cheng Zhao) nodejs#49279 stream: * use bitmap in writable state (Raz Luvaton) nodejs#49834 * use bitmap in readable state (Benjamin Gruenbaum) nodejs#49745 * improve webstream readable async iterator performance (Raz Luvaton) nodejs#49662 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) nodejs#49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) nodejs#49614 PR-URL: nodejs#49932

PR-URL: nodejs/node#49745 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs/node#49908 * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team) nodejs/node#50531 doc: * move and rename loaders section (Geoffrey Booth) nodejs/node#49261 esm: * use import attributes instead of import assertions (Antoine du Hamel) nodejs/node#50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs/node#49869 * unflag import.meta.resolve (Guy Bedford) nodejs/node#49028 * move hook execution to separate thread (Jacob Smith) nodejs/node#44710 * leverage loaders when resolving subsequent loaders (Maël Nison) nodejs/node#43772 lib: * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) nodejs/node#46391 * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger) nodejs/node#44943 src: * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan) nodejs/node#45629 stream: * use bitmap in readable state (Benjamin Gruenbaum) nodejs/node#49745 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) nodejs/node#49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) nodejs/node#49614 * (SEMVER-MINOR) expose location of tests (Colin Ihrig) nodejs/node#48975 * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs/node#48639 * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs/node#47775 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs/node#49996 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs/node#45190 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs/node#50141 PR-URL: nodejs/node#50953

PR-URL: nodejs/node#49745 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Notable changes: deps: * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs/node#49908 * (SEMVER-MINOR) upgrade npm to 10.2.3 (npm team) nodejs/node#50531 doc: * move and rename loaders section (Geoffrey Booth) nodejs/node#49261 esm: * use import attributes instead of import assertions (Antoine du Hamel) nodejs/node#50140 * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs/node#49869 * unflag import.meta.resolve (Guy Bedford) nodejs/node#49028 * move hook execution to separate thread (Jacob Smith) nodejs/node#44710 * leverage loaders when resolving subsequent loaders (Maël Nison) nodejs/node#43772 lib: * (SEMVER-MINOR) add api to detect whether source-maps are enabled (翠 / green) nodejs/node#46391 * (SEMVER-MINOR) add tracing channel to diagnostics_channel (Stephen Belanger) nodejs/node#44943 src: * (SEMVER-MINOR) add cjs_module_lexer_version base64_version (Jithil P Ponnan) nodejs/node#45629 stream: * use bitmap in readable state (Benjamin Gruenbaum) nodejs/node#49745 test_runner: * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) nodejs/node#49753 * (SEMVER-MINOR) add junit reporter (Moshe Atlow) nodejs/node#49614 * (SEMVER-MINOR) expose location of tests (Colin Ihrig) nodejs/node#48975 * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs/node#48639 * (SEMVER-MINOR) add initial draft for fakeTimers (Erick Wendel) nodejs/node#47775 test_runner, cli: * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs/node#49996 tls: * (SEMVER-MINOR) add ALPNCallback server option for dynamic ALPN negotiation (Tim Perry) nodejs/node#45190 vm: * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs/node#50141 PR-URL: nodejs/node#50953

stream: use bitmap in readable state

1cea18d

benjamingr added the stream Issues and PRs related to the stream subsystem. label Sep 21, 2023

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 21, 2023

benjamingr mentioned this pull request Sep 21, 2023

Stream performance improvement ideas nodejs/performance#117

Open

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023

fixup! dont let copilot generate code

e2d09e3

H4ad reviewed Sep 21, 2023

View reviewed changes

fixup! dont let copilot generate code

f6a09c7

benjamingr added 2 commits September 21, 2023 12:39

a bit more testing

e2e1f77

fixup! convert more to bitmap

b14ba74

fixup!

5013d25

ronag reviewed Sep 21, 2023

View reviewed changes

lib/internal/streams/readable.js Show resolved Hide resolved

ronag reviewed Sep 21, 2023

View reviewed changes

lib/internal/streams/readable.js Outdated Show resolved Hide resolved

anonrig reviewed Sep 21, 2023

View reviewed changes

ronag reviewed Sep 21, 2023

View reviewed changes

lpinca added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 21, 2023

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023

ronag approved these changes Sep 24, 2023

View reviewed changes

benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2023

nodejs-github-bot merged commit e2245dd into nodejs:main Sep 24, 2023
55 checks passed

joyeecheung mentioned this pull request Sep 25, 2023

wpt/test-structured-clone is flaky #49852

Closed

github-actions bot mentioned this pull request Sep 27, 2023

CI Reliability 2023-09-27 nodejs/reliability#676

Open

21 tasks

ruyadorno mentioned this pull request Sep 28, 2023

v20.7.1 proposal #49917

Closed

ruyadorno mentioned this pull request Sep 28, 2023

v20.8.0 proposal #49932

Merged

azu mentioned this pull request Oct 3, 2023

2023-10-03のJS: Node v20.8.0、Vitest v1.0.0-beta.0、instant.dev(Rails-inspired ORM/Migrations) jser/jser.github.io#1123

Merged

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

dead-claudia mentioned this pull request Feb 12, 2024

Bitwise operations are seemingly not minimized or optimized at all terser/terser#1343

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stream: use bitmap in readable state #49745

stream: use bitmap in readable state #49745

benjamingr commented Sep 21, 2023

nodejs-github-bot commented Sep 21, 2023

nodejs-github-bot commented Sep 21, 2023

benjamingr commented Sep 21, 2023

H4ad Sep 21, 2023

benjamingr Sep 21, 2023

ronag Sep 21, 2023

benjamingr Sep 21, 2023

benjamingr commented Sep 21, 2023

benjamingr commented Sep 21, 2023 •

edited

Loading

benjamingr commented Sep 21, 2023 •

edited

Loading

anonrig Sep 21, 2023

benjamingr Sep 21, 2023

ronag left a comment

benjamingr commented Sep 21, 2023

benjamingr commented Sep 21, 2023

benjamingr commented Sep 21, 2023

lpinca commented Sep 21, 2023

lpinca commented Sep 21, 2023

benjamingr commented Sep 21, 2023

nodejs-github-bot commented Sep 24, 2023

	if (options && options.objectMode) this.state \|= kObjectMode;
	if (options?.objectMode) this.state \|= kObjectMode;

stream: use bitmap in readable state #49745

stream: use bitmap in readable state #49745

Conversation

benjamingr commented Sep 21, 2023

nodejs-github-bot commented Sep 21, 2023

nodejs-github-bot commented Sep 21, 2023

benjamingr commented Sep 21, 2023

H4ad Sep 21, 2023

Choose a reason for hiding this comment

benjamingr Sep 21, 2023

Choose a reason for hiding this comment

ronag Sep 21, 2023

Choose a reason for hiding this comment

benjamingr Sep 21, 2023

Choose a reason for hiding this comment

benjamingr commented Sep 21, 2023

benjamingr commented Sep 21, 2023 • edited Loading

benjamingr commented Sep 21, 2023 • edited Loading

anonrig Sep 21, 2023

Choose a reason for hiding this comment

benjamingr Sep 21, 2023

Choose a reason for hiding this comment

ronag left a comment

Choose a reason for hiding this comment

benjamingr commented Sep 21, 2023

benjamingr commented Sep 21, 2023

benjamingr commented Sep 21, 2023

lpinca commented Sep 21, 2023

lpinca commented Sep 21, 2023

benjamingr commented Sep 21, 2023

nodejs-github-bot commented Sep 24, 2023

benjamingr commented Sep 21, 2023 •

edited

Loading

benjamingr commented Sep 21, 2023 •

edited

Loading