Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update icu to #50495

Closed
wants to merge 1 commit into from
Closed

deps: update icu to #50495

wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of icu to .

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Nov 1, 2023
@marco-ippolito
Copy link
Member

marco-ippolito commented Nov 1, 2023 •
edited
Loading

update ICU to what? 😄 I guess it's a bug, also it's not updating the maintaining-dependencies list
@nodejs/security-wg

@marco-ippolito marco-ippolito mentioned this pull request Nov 1, 2023
Open
@targos
Copy link
Member

targos commented Nov 1, 2023

https://github.com/nodejs/node/actions/runs/6717282091/job/18254870034

Comparing checksums: deposited  with 71e60b22697c4f35820a1897417dbab4
Skipped because checksums do not match.

The script should probably end with an error if there is a checksum problem.

@targos
Copy link
Member

targos commented Nov 1, 2023

I'd like to retry it.

@targos targos closed this Nov 1, 2023
@targos targos deleted the actions/tools-update-icu branch November 1, 2023 08:47
targos added a commit to targos/node that referenced this pull request Nov 2, 2023
@targos
tools: compare ICU checksums before file changes
582ff30 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: nodejs#50495
@targos targos mentioned this pull request Nov 2, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Nov 6, 2023
@targos
tools: compare ICU checksums before file changes
cde3296 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Nov 9, 2023
@targos @anonrig
tools: compare ICU checksums before file changes
fc13920 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: nodejs#50495
PR-URL: nodejs#50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Nov 11, 2023
@targos
tools: compare ICU checksums before file changes
c50b9b3 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Nov 14, 2023
@targos
tools: compare ICU checksums before file changes
257e220 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@targos @UlisesGascon
tools: compare ICU checksums before file changes
2fd78fc 
Otherwise we end up with an bad update PR when checksums don't match.

Refs: #50495
PR-URL: #50522
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@srl295
Copy link
Member

srl295 commented Jan 8, 2024

Why didn't it match? was the release broken or transient err?

@targos
Copy link
Member

targos commented Jan 8, 2024

It was #50498 (missing checksum files in the release artifacts)

@srl295
Copy link
Member

srl295 commented Jan 8, 2024

Thanks.

74.2 had a broken LICENSE file, not sure if that has been corrected.

@targos
Copy link
Member

targos commented Jan 8, 2024

The problem with 74.2 is that it's still a Pre-release on GitHub: https://github.com/unicode-org/icu/releases

@richardlau
Copy link
Member

The problem with 74.2 is that it's still a Pre-release on GitHub: https://github.com/unicode-org/icu/releases

FWIW I opened an issue for this last week: https://unicode-org.atlassian.net/browse/ICU-22622

@srl295
Copy link
Member

srl295 commented Jan 8, 2024

The problem with 74.2 is that it's still a Pre-release on GitHub: https://github.com/unicode-org/icu/releases

FWIW I opened an issue for this last week: https://unicode-org.atlassian.net/browse/ICU-22622

cross linked to another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nodejs-github-bot @marco-ippolito @targos @srl295 @richardlau