Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: introduce PullAll method to speed up blob.text/arrayBuffer #52546

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

src: introduce PullAll method to speed up blob.text/arrayBuffer #52546

wants to merge 2 commits into from
+106 −22

Conversation

debadree25
Copy link
Member

Refs: nodejs/performance#118

This is a reopen of #49873 due to a rebase mess up

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 15, 2024
@debadree25

This comment was marked as outdated.

Sign in to view
@debadree25 debadree25 marked this pull request as ready for review April 15, 2024 19:30
@debadree25
Copy link
Member Author

Okay the PR seems to be working but curiously seems not to be faster somehow :-(

Also cc @lemire have addressed your comments from the previous pr #52546 In case you would like to review again! Thank you very much!

@debadree25 debadree25 requested a review from lemire April 15, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire Awaiting requested review from lemire

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debadree25 @nodejs-github-bot