Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: deprecate NaN or negative number as delay to setTimeout and setInterval #53005

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+21 −0
Open

doc: deprecate NaN or negative number as delay to setTimeout and setInterval #53005

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7603d2e
doc: deprecate NaN or negative number as delay
jakecastelli May 15, 2024
4c01bc6
fixup
jakecastelli May 15, 2024
6e27ebb
fixup - add entry to `deprecations`
jakecastelli May 15, 2024
6cf7e84
fixup
jakecastelli May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions doc/api/timers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,10 @@
<!-- YAML
added: v0.0.1
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/46678

Check warning on line 228 in doc/api/timers.md

View workflow job for this annotation

GitHub Actions / lint-pr-url 

pr-url doesn't match the URL of the current PR.
jakecastelli marked this conversation as resolved.
Show resolved Hide resolved
description: Passing `NaN` or negative number as `delay` will result
the process to emit a warning, the warning will only be emitted once per process.
jakecastelli marked this conversation as resolved.
Show resolved Hide resolved
- version: v18.0.0
pr-url: https://github.com/nodejs/node/pull/41678
description: Passing an invalid callback to the `callback` argument
Expand Down Expand Up @@ -252,6 +256,10 @@
<!-- YAML
added: v0.0.1
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/46678

Check warning on line 260 in doc/api/timers.md

View workflow job for this annotation

GitHub Actions / lint-pr-url 

pr-url doesn't match the URL of the current PR.
description: Passing `NaN` or negative number as `delay` will result
the process to emit a warning, the warning will only be emitted once per process.
- version: v18.0.0
pr-url: https://github.com/nodejs/node/pull/41678
description: Passing an invalid callback to the `callback` argument
Expand Down