Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: prevent format from being set to null internaly #53015

Closed
wants to merge 5 commits into from
Closed

module: prevent format from being set to null internaly #53015

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86299ac
module: prevent `format` from being `null`
RedYetiDev May 15, 2024
36e847e
Update formats.js
RedYetiDev May 15, 2024
78e756b
Update formats.js
RedYetiDev May 15, 2024
fcc5d01
Update module.md
RedYetiDev May 15, 2024
937be1b
Update module.md
RedYetiDev May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Update formats.js
  • Loading branch information
@RedYetiDev
RedYetiDev committed May 15, 2024
commit 36e847ec2ea6224bffc04585f351188094e4ec9d
1 change: 0 additions & 1 deletion lib/internal/modules/esm/formats.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
extensionFormatMap['.wasm'] = 'wasm';
}

/**

Check warning on line 27 in lib/internal/modules/esm/formats.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

JSDoc @returns declaration present but return expression not available in function
* @param {string} mime
* @returns {string | null}
*/
Expand All @@ -37,7 +37,6 @@
) { return 'module'; }
if (mime === 'application/json') { return 'json'; }
if (experimentalWasmModules && mime === 'application/wasm') { return 'wasm'; }
return;
}

/**
Expand Down