-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: fix execArgv in worker #53029
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
theanarkh:fix_exec_argv_in_worker
May 23, 2024
Merged
src: fix execArgv in worker #53029
nodejs-github-bot
merged 1 commit into
nodejs:main
from
theanarkh:fix_exec_argv_in_worker
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
worker
Issues and PRs related to Worker support.
labels
May 16, 2024
theanarkh
force-pushed
the
fix_exec_argv_in_worker
branch
3 times, most recently
from
May 16, 2024 19:07
a5961c7
to
07b3e88
Compare
anonrig
approved these changes
May 16, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 16, 2024
This comment was marked as outdated.
This comment was marked as outdated.
theanarkh
force-pushed
the
fix_exec_argv_in_worker
branch
from
May 17, 2024 15:20
07b3e88
to
c5fc44c
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 18, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
reviewed
May 20, 2024
theanarkh
force-pushed
the
fix_exec_argv_in_worker
branch
from
May 20, 2024 18:15
c5fc44c
to
41cfbf5
Compare
aduh95
approved these changes
May 20, 2024
theanarkh
force-pushed
the
fix_exec_argv_in_worker
branch
from
May 20, 2024 19:02
41cfbf5
to
79986bc
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
In the future we can consider relaxing the check even more, to be "throw if there is any invalid execArgv that was not also an execArgv of the parent", so that these other test cases would pass:
// allow explicitly passing the default execArgv value
new Worker(CODE, { eval: true, execArgv: process.execArgv });
// run with the worker with the same config as the parent, except for --expose-internals
new Worker(CODE, { eval: true, execArgv: process.execArgv.filter(n => n !== "--expose-internals" });
theanarkh
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 23, 2024
aduh95
approved these changes
May 23, 2024
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 23, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 23, 2024
Landed in c137d6e |
Merged
EliphazBouye
pushed a commit
to EliphazBouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53029 Fixes: nodejs#53011 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53029 Fixes: nodejs#53011 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
worker
Issues and PRs related to Worker support.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #53011
make -j4 test
(UNIX), orvcbuild test
(Windows) passes