-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor, add assertion to http-request-end #53411
Open
jakecastelli
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
jakecastelli:improve-http-request-end-test
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: refactor, add assertion to http-request-end #53411
jakecastelli
wants to merge
1
commit into
nodejs:main
from
jakecastelli:improve-http-request-end-test
+7
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Linux (without intl) / coverage-linux-without-intl failed?? 👀 |
JS tests didn't run because of a flaky C++ test (#47427). I rerun the workflow. |
lpinca
approved these changes
Jun 12, 2024
280fcaa
to
4c75b9b
Compare
CI rerun failed again due to build failed, I think because it needs a rebase. I have just rebased, should be good now 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running tests with
./node test/parallel/test-http-request-end.js
and seeing200
printed to the console. Replaced the log with assertion and addedmustCall
to make the test more strict.