-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: fix typings #53626
fs: fix typings #53626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does more than just fix typings, can you amend the commit message to reflect that? (or split the PR if the other changes were meant to be separated)
I spent 5+ minutes but couldn't find a good commit message. Any suggestions? |
Commit Queue failed- Loading data for nodejs/node/pull/53626 ✔ Done loading data for nodejs/node/pull/53626 ----------------------------------- PR info ------------------------------------ Title fs: fix typings (#53626) Author Yagiz Nizipli (@anonrig) Branch anonrig:fs-fix-typings -> nodejs:main Labels fs, needs-ci, typings Commits 2 - fs: fix typings - Update lib/fs.js Committers 2 - Yagiz Nizipli - GitHub PR-URL: https://github.com/nodejs/node/pull/53626 Reviewed-By: Antoine du Hamel Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53626 Reviewed-By: Antoine du Hamel Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 28 Jun 2024 14:37:25 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/53626#pullrequestreview-2149611133 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53626#pullrequestreview-2157909752 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-07-04T01:28:41Z: https://ci.nodejs.org/job/node-test-pull-request/60053/ - Querying data for job/node-test-pull-request/60053/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 53626 From https://github.com/nodejs/node * branch refs/pull/53626/merge -> FETCH_HEAD ✔ Fetched commits as ce2faef3a70a..634bd62d0c03 -------------------------------------------------------------------------------- Auto-merging typings/internalBinding/fs.d.ts [main c482d15044] fs: fix typings Author: Yagiz Nizipli Date: Fri Jun 28 10:37:10 2024 -0400 2 files changed, 20 insertions(+), 20 deletions(-) [main 8e868d2d04] Update lib/fs.js Author: Yagiz Nizipli Date: Fri Jun 28 10:52:24 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/9792871085 |
Landed in f1ac7df |
PR-URL: #53626 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #53626 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #53626 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fix jsdoc and typescript types in lib/fs.js