-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use correct file naming syntax for util-parse-env
#53705
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Is this good to land? |
This comment was marked as outdated.
This comment was marked as outdated.
Tests are failing :-/, CC @IlyasShabi |
The issue was that the fixture was updated in a different PR, leading this file to remain unupdated. It is now updated. |
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53705 +/- ##
==========================================
+ Coverage 87.90% 87.91% +0.01%
==========================================
Files 651 651
Lines 183343 183343
Branches 35710 35712 +2
==========================================
+ Hits 161165 161187 +22
+ Misses 15466 15433 -33
- Partials 6712 6723 +11 |
(rebased |
Failed to start CI⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/10444728825 |
😅 I always forget which different little peices cause the CI to fail to start... |
This should be good now that I've fixed the tests to account for the newer changes, could someone start a new CI to verify that? |
This comment was marked as outdated.
This comment was marked as outdated.
CI is passing + many approving reviews, |
This comment was marked as outdated.
This comment was marked as outdated.
There are 3 failing checks. Can you rebase and force push? We can't land a pull-request when existing CI is failing. |
This comment was marked as outdated.
This comment was marked as outdated.
Rebased. |
FWIW CI failures are flakes |
Landed in b4088f5 |
PR-URL: #53705 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #53705 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #53705 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The project's test runner will only run files beginning with
test-
, so this PR fixesutil-parse-env.js
totest-util-parse-env.js
.