lib: support dynamic trace events on debugWithTimer #53913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
benjamingr
approved these changes
Jul 27, 2024
RafaelGSS
approved these changes
Jul 27, 2024
RafaelGSS
added
author ready
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
H4ad
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53913 ✔ Done loading data for nodejs/node/pull/53913 ----------------------------------- PR info ------------------------------------ Title lib: support dynamic trace events on debugWithTimer (#53913) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch H4ad:refactor-my-todo-pt2 -> nodejs:main Labels util, author ready, needs-ci, commit-queue-squash Commits 4 - lib: support dynamic trace events on debugWithTimer - minor fix on lint - fix issue with trace events not found - fix lint on test Committers 1 - Vinícius Lourenço <contact@viniciusl.com.br> PR-URL: https://github.com/nodejs/node/pull/53913 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53913 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - fix issue with trace events not found ⚠ - fix lint on test ℹ This PR was created on Thu, 18 Jul 2024 01:12:49 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53913#pullrequestreview-2203195839 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/53913#pullrequestreview-2203199177 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-07-27T21:59:36Z: https://ci.nodejs.org/job/node-test-pull-request/60680/ - Querying data for job/node-test-pull-request/60680/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10131853902 |
RafaelGSS
approved these changes
Jul 28, 2024
RafaelGSS
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 01cf9bc |
targos
pushed a commit
that referenced
this pull request
Jul 30, 2024
PR-URL: #53913 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #53913 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing an old TODO that I leave to myself to support trace events that are enabled dynamically.
Refs: #52213 (comment)