Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: refactoring for supporting in-process testing #53921

Merged
merged 1 commit into from
Jul 20, 2024
Merged

test_runner: refactoring for supporting in-process testing #53921

merged 1 commit into from
Jul 20, 2024

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 18, 2024 •
edited
Loading

Hopefully this is the last bit of refactoring before adding support for running multiple test files in the same process.

@cjihrig
test_runner: refactor and simplify internals
2d7018c 
This commit refactors some of the internals of the test runner.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jul 18, 2024
atlowChemi
atlowChemi approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@atlowChemi atlowChemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but shouldn't the change in the order of before hook be considered a breaking change? (hence semver-major)

@cjihrig
Copy link
Contributor Author

cjihrig commented Jul 18, 2024

@atlowChemi I have backed out that change for now. I think it may be fine for the purposes of test isolation.

I do think it is a minor bug though. We have an allowTestsToRun flag in the test harness that is supposed to prevent the runner from executing anything until we tell it to. Top level before hooks currently violate that.

mcollina
mcollina approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjihrig cjihrig mentioned this pull request Jul 18, 2024
Closed
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 18, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60430/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60443/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60452/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60470/

@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jul 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit dab12a2 into nodejs:main Jul 20, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in dab12a2

@cjihrig cjihrig deleted the refactor branch July 20, 2024 16:59
targos pushed a commit that referenced this pull request Jul 28, 2024
@cjihrig @targos
test_runner: refactor and simplify internals
f45edb4 
This commit refactors some of the internals of the test runner.

PR-URL: #53921
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@MoLow MoLow MoLow approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @mcollina @jasnell @benjamingr @MoLow @atlowChemi @targos