build: always disable strict aliasing #54339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V8 relies on it.
|
Review requested:
|
nodejs-github-bot
added
build
|
Context: #54077 (comment), Line 108 in 624db50 |
richardlau
approved these changes
Aug 12, 2024
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Aug 13, 2024
lpinca
approved these changes
Aug 13, 2024
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2573f74 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 19, 2024
V8 relies on it. PR-URL: #54339 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 21, 2024
V8 relies on it. PR-URL: #54339 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bnoordhuis
added a commit
to bnoordhuis/mini_racer
that referenced
this pull request
Sep 17, 2024
Harmonize C++ compiler flags with Node.js (-fno-rtti, -fno-exceptions) and, critically, disable strict aliasing, because V8 is not the least bit strict-aliasing safe. Upstream turned it off in nodejs/node#54339, like it always should have been, and I suspect the mismatch may be the cause of segfaults that show up in production. Remove -fpermissive, it's not needed and something to discourage.
bnoordhuis
added a commit
to bnoordhuis/mini_racer
that referenced
this pull request
Sep 17, 2024
Harmonize C++ compiler flags with Node.js (-fno-rtti, -fno-exceptions) and, critically, disable strict aliasing, because V8 is not the least bit strict-aliasing safe. Upstream turned it off in nodejs/node#54339, like it always should have been, and I suspect the mismatch may be the cause of segfaults that show up in production. Remove -fpermissive, it's not needed and something to discourage.
bnoordhuis
added a commit
to bnoordhuis/mini_racer
that referenced
this pull request
Sep 17, 2024
Harmonize C++ compiler flags with Node.js (-fno-rtti, -fno-exceptions) and, critically, disable strict aliasing, because V8 is not the least bit strict-aliasing safe. Upstream turned it off in nodejs/node#54339, like it always should have been, and I suspect the mismatch may be the cause of segfaults that show up in production.
SamSaffron
pushed a commit
to rubyjs/mini_racer
that referenced
this pull request
Sep 17, 2024
Harmonize C++ compiler flags with Node.js (-fno-rtti, -fno-exceptions) and, critically, disable strict aliasing, because V8 is not the least bit strict-aliasing safe. Upstream turned it off in nodejs/node#54339, like it always should have been, and I suspect the mismatch may be the cause of segfaults that show up in production.
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 relies on it.