Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #54640

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Fix typo #54640

merged 1 commit into from
Aug 31, 2024

Conversation

mhdawson
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 29, 2024
@mhdawson
doc: fix typo
7368007 
name used instructions differed that what is in the code

Signed-off-by: Michael Dawson <midawson@redhat.com>
@RedYetiDev RedYetiDev added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. and removed needs-ci PRs that need a full CI run. labels Aug 29, 2024
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 30, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 31, 2024
@nodejs-github-bot nodejs-github-bot merged commit a1ffa64 into nodejs:main Aug 31, 2024
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a1ffa64

sendoru pushed a commit to sendoru/node that referenced this pull request Sep 1, 2024
@mhdawson @sendoru
doc: fix typo
618ffe7 
name used instructions differed that what is in the code

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#54640
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@mhdawson @aduh95
doc: fix typo
5555095 
name used instructions differed that what is in the code

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54640
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@Flarna Flarna Flarna approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mhdawson @nodejs-github-bot @lpinca @richardlau @Flarna @jakecastelli @aduh95 @RedYetiDev