-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix broken Android building link #54922
Merged
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
process
Issues and PRs related to the process subsystem.
labels
Sep 13, 2024
richardlau
approved these changes
Sep 13, 2024
nikwen
changed the title
docs: fix broken Android building link
doc: fix broken Android building link
Sep 13, 2024
Fixed the commit message! |
richardlau
approved these changes
Sep 13, 2024
lpinca
approved these changes
Sep 13, 2024
RedYetiDev
added
build
Issues and PRs related to build files or the CI.
android
Issues and PRs related to the android platform.
labels
Sep 13, 2024
meixg
approved these changes
Sep 13, 2024
Thanks for the reviews, everyone! Just noticed the link was also used in one other place, so I fixed that, too. |
richardlau
approved these changes
Sep 13, 2024
lpinca
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Sep 14, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 15, 2024
Landed in 4c0ad1f |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
PR-URL: #54922 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 16, 2024
PR-URL: #54922 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
PR-URL: #54922 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 17, 2024
PR-URL: #54922 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
android
Issues and PRs related to the android platform.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
build
Issues and PRs related to build files or the CI.
doc
Issues and PRs related to the documentations.
process
Issues and PRs related to the process subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old link is broken.