Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade libuv to 1.9.0 #5994

Merged
merged 1 commit into from
Apr 7, 2016
Merged

deps: upgrade libuv to 1.9.0 #5994

merged 1 commit into from
Apr 7, 2016

Conversation

saghul
Copy link
Member

@saghul saghul commented Apr 1, 2016

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

deps / libuv

Description of change

WIP, just to get the ball rolling. The release is near, so better run this through the CI to see there are no problems (running tests locally on OSX yields good hope).

I referenced all Node issues I could find, if you know of any others please let me know!

Fixes: #5737
Fixes: #4643
Fixes: #4291
Fixes: nodejs/node-v0.x-archive#8960

@saghul saghul changed the title deps: upgrade libuv to 1.9.0 [WIP] deps: upgrade libuv to 1.9.0 Apr 1, 2016
@r-52 r-52 added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Apr 1, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Apr 1, 2016

Rubber stamp LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/2118/

@cjihrig
Copy link
Contributor

cjihrig commented Apr 1, 2016

CI is all 💚

@saghul
Copy link
Member Author

saghul commented Apr 1, 2016

Sweet! Let's give it a couple more days to see if we can land those 2 items in libuv and make an actual release!

@Fishrock123
Copy link
Contributor

I think this also allows #3594 to work?

@jasnell
Copy link
Member

jasnell commented Apr 1, 2016

Woohoo! rubber stamp LGTM

@Trott
Copy link
Member

Trott commented Apr 1, 2016

@saghul There's nothing in 1.9.0 that will help with #954 by any chance, is there? (Doesn't look like it to me, but I can be less-than-perceptive on these sorts of things...)

@saghul
Copy link
Member Author

saghul commented Apr 2, 2016

I'm afraid not. I tried to reproduce the original problem a while ago,
without success.
On Apr 1, 2016 18:21, "Rich Trott" notifications@github.com wrote:

@saghul https://github.com/saghul There's nothing in 1.9.0 that will
help with #954 #954 by any chance,
is there? (Doesn't look like it to me, but I can be less-than-perceptive on
these sorts of things...)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5994 (comment)

@saghul
Copy link
Member Author

saghul commented Apr 2, 2016

It does, I'll mention it in the commit message.
On Apr 1, 2016 11:55, "Jeremiah Senkpiel" notifications@github.com wrote:

I think this also allows #3594 #3594
to work?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#5994 (comment)

@mscdex
Copy link
Contributor

mscdex commented Apr 6, 2016

Any update on the timeline for the release?

@cjihrig
Copy link
Contributor

cjihrig commented Apr 6, 2016

@saghul saghul changed the title [WIP] deps: upgrade libuv to 1.9.0 deps: upgrade libuv to 1.9.0 Apr 7, 2016
@saghul
Copy link
Member Author

saghul commented Apr 7, 2016

libuv 1.9.0 is out and about. I added the extra changes here.

CI: https://ci.nodejs.org/job/node-test-pull-request/2193/

@saghul
Copy link
Member Author

saghul commented Apr 7, 2016

@bnoordhuis
Copy link
Member

Forgot about CERTIFY_SAFE? :-) Rubber-stamp LGTM.

@cjihrig
Copy link
Contributor

cjihrig commented Apr 7, 2016

Still LGTM

@jbergstroem
Copy link
Member

LGTM. Fail look unrelated.

@saghul saghul merged commit 55a964e into nodejs:master Apr 7, 2016
@saghul
Copy link
Member Author

saghul commented Apr 7, 2016

Thanks everyone for the reviews! Landed! 🎉

@cjihrig
Copy link
Contributor

cjihrig commented Apr 7, 2016

If you can do it fast enough, you might want to force push and add Reviewed-By metadata.

@saghul
Copy link
Member Author

saghul commented Apr 7, 2016

F*ck, I added it, but I guess I managed to delete it :-( Will fix.

saghul added a commit that referenced this pull request Apr 7, 2016
Fixes: #5737
Fixes: #4643
Fixes: #4291
Fixes: nodejs/node-v0.x-archive#8960
Refs: #3594
PR-URL: #5994
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@saghul
Copy link
Member Author

saghul commented Apr 7, 2016

Force pushed. Thanks for noticing Colin! I'm not sure what happened there 😢

@cjihrig
Copy link
Contributor

cjihrig commented Apr 7, 2016

Thanks for fixing so quickly.

@MylesBorins
Copy link
Contributor

@saghul exactly what @jasnell said. While fixing the bugs is a top priority... those bugs have existed for a bit and people to some extent expect them. The breakages that have been reported are new, and workflow breaking. I felt uncomfortable putting this on 5 knowing that we would be shipping workflow breaking changes, especially since this is going to be included in 6 next week.

@kzc
Copy link

kzc commented Apr 21, 2016

While fixing the bugs is a top priority... those bugs have existed for a bit and people to some extent expect them.

I disagree with this statement. A bug is a bug. Just because older bugs weren't addressed in a timely fashion does not mean they are less important.

As for process.exit not flushing stdout and stderr, this has always been problematic throughout node's existence. Although the node 4.x and 5.x series happened to flush stdout for david upon process.exit there is no guarantee it works in the general case.

@jasnell
Copy link
Member

jasnell commented Apr 21, 2016

@kzc ... it's not that the bugs aren't important.. it's definitely important to fix them! It's just that we need to be a bit cautious about pulling the libuv update into v4 until we can make sure that there are no additional unforeseen impacts. That's not to say we'll never pull it back, just that we may need to give it a few weeks while we, and the ecosystem, get things tested.

@kzc
Copy link

kzc commented Apr 21, 2016

@jasnell Do you acknowledge that the behavior of flushing stdout/stderr upon process.exit has always been and remains undefined?

@MylesBorins
Copy link
Contributor

@kzc, perhaps I didn't do a good job of expressing my intentions

v5 is end of life. There are not going to be many more releases of it. v6 is being released on Tuesday.

This patch will land in v6 on tuesday. What I have opted to do is not land it on v5 as we don't know yet exactly what effect this will have on the ecosystem. This will leave v5 in a state similar to where it already is, and allow the regressions to be found in v6.

Once we have an idea of exactly what regressions there are, and assuming those regressions are not going to cause a serious problem, this will be able to be backported to v4.

What I want to avoid is having to cut multiple v5's, or potentially leaving v5 in a less stable state by landing this upgrade.

@saghul
Copy link
Member Author

saghul commented Apr 21, 2016

@thealphanerd I wasn't aware of 5 being EOL, 👍 then!

@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 21, 2016

There will still be a couple updates, but the idea is that it is winding down. Below you can see the current LTS schedule

schedule

@jasnell
Copy link
Member

jasnell commented Apr 21, 2016

It's EOL_-ish_. It's likely to still have a bit more life in it over the next month or two, it's just not the priority once v6 comes out.

@kzc
Copy link

kzc commented Apr 24, 2016

@mgol reported that another process.exit() issue came to light in a popular third party app. The process.exit issue is likely quite common with node command line apps. Should hold off on merging libuv 1.9.0 into node 6 release in its present state.

saghul added a commit to saghul/node that referenced this pull request Jul 11, 2016
Fixes: nodejs#5737
Fixes: nodejs#4643
Fixes: nodejs#4291
Fixes: nodejs/node-v0.x-archive#8960
Refs: nodejs#3594
PR-URL: nodejs#5994
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
Fixes: #5737
Fixes: #4643
Fixes: #4291
Fixes: nodejs/node-v0.x-archive#8960
Refs: #3594
PR-URL: #5994
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
Fixes: #5737
Fixes: #4643
Fixes: #4291
Fixes: nodejs/node-v0.x-archive#8960
Refs: #3594
PR-URL: #5994
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Fixes: #5737
Fixes: #4643
Fixes: #4291
Fixes: nodejs/node-v0.x-archive#8960
Refs: #3594
PR-URL: #5994
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Notable Changes:

This list is not yet complete. Please comment in the thread with
commits you think should be included. Descriptions will also be
updated in a later release candidate.

Semver Minor:

* buffer:
 * backport new buffer constructor APIs to v4.x
   (Сковорода Никита Андреевич)
   #7562
 * ignore negative allocation lengths (Anna Henningsen)
   #7562
 * backport --zero-fill-buffers cli option (James M Snell)
   #5745
* build:
  * add Intel Vtune profiling support (Chunyang Dai)
    #5527
* repl:
  * copying tabs shouldn't trigger completion (Eugene Obrezkov)
    #5958
* src:
  * add node::FreeEnvironment public API (Cheng Zhao)
    #3098
* test:
  * run v8 tests from node tree (Bryon Leung)
    #4704
* V8:
  * backport 9c927d0f01 from V8 upstream (Myles Borins)
    #7451
  * cherry-pick 68e89fb from v8's upstream (Fedor Indutny)
    #3779

Semver Patch:

* **libuv**:
  * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    #6796
  * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé)
    #5994
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 13, 2016
Notable Changes:

This list is not yet complete. Please comment in the thread with
commits you think should be included. Descriptions will also be
updated in a later release candidate.

Semver Minor:

* buffer:
 * backport new buffer constructor APIs to v4.x
   (Сковорода Никита Андреевич)
   #7562
 * ignore negative allocation lengths (Anna Henningsen)
   #7562
 * backport --zero-fill-buffers cli option (James M Snell)
   #5745
* build:
  * add Intel Vtune profiling support (Chunyang Dai)
    #5527
* repl:
  * copying tabs shouldn't trigger completion (Eugene Obrezkov)
    #5958
* src:
  * add node::FreeEnvironment public API (Cheng Zhao)
    #3098
* test:
  * run v8 tests from node tree (Bryon Leung)
    #4704
* V8:
  * Add post portem data to imrpove object inspection and function's
    context variables inspection (Fedor Indutny)
    #3779

Semver Patch:

* **libuv**:
  * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    #6796
  * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé)
    #5994
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Fixes: #5737
Fixes: #4643
Fixes: #4291
Fixes: nodejs/node-v0.x-archive#8960
Refs: #3594
PR-URL: #5994
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Fixes: #5737
Fixes: #4643
Fixes: #4291
Fixes: nodejs/node-v0.x-archive#8960
Refs: #3594
PR-URL: #5994
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Notable Changes:

This list is not yet complete. Please comment in the thread with
commits you think should be included. Descriptions will also be
updated in a later release candidate.

Semver Minor:

* buffer:
 * backport new buffer constructor APIs to v4.x
   (Сковорода Никита Андреевич)
   #7562
 * backport --zero-fill-buffers cli option (James M Snell)
   #5745
* build:
  * add Intel Vtune profiling support (Chunyang Dai)
    #5527
* repl:
  * copying tabs shouldn't trigger completion (Eugene Obrezkov)
    #5958
* src:
  * add node::FreeEnvironment public API (Cheng Zhao)
    #3098
* test:
  * run v8 tests from node tree (Bryon Leung)
    #4704
* V8:
  * Add post portem data to imrpove object inspection and function's
    context variables inspection (Fedor Indutny)
    #3779

Semver Patch:

* **buffer**:
  * ignore negative allocation lengths (Anna Henningsen)
    #7562
* **libuv**:
  * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    #6796
  * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé)
    #5994
* **npm**:
  * upgrade to 2.15.9 (Kat Marchán)
    #7692
MylesBorins pushed a commit that referenced this pull request Aug 15, 2016
Notable Changes:

Semver Minor:

* buffer:
 * backport new buffer constructor APIs to v4.x
   (Сковорода Никита Андреевич)
   #7562
 * backport --zero-fill-buffers cli option (James M Snell)
   #5745
* build:
  * add Intel Vtune profiling support (Chunyang Dai)
    #5527
* repl:
  * copying tabs shouldn't trigger completion (Eugene Obrezkov)
    #5958
* src:
  * add node::FreeEnvironment public API (Cheng Zhao)
    #3098
* test:
  * run v8 tests from node tree (Bryon Leung)
    #4704
* V8:
  * Add post mortem data to improve object inspection and function's
    context variables inspection (Fedor Indutny)
    #3779

Semver Patch:

* **buffer**:
  * ignore negative allocation lengths (Anna Henningsen)
    #7562
* **crypto**:
  * update root certificates (Ben Noordhuis)
    #7363
* **libuv**:
  * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    #6796
  * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé)
    #5994
* **npm**:
  * upgrade to 2.15.9 (Kat Marchán)
    #7692
MylesBorins pushed a commit that referenced this pull request Aug 16, 2016
Notable Changes:

Semver Minor:

* buffer:
 * backport new buffer constructor APIs to v4.x
   (Сковорода Никита Андреевич)
   #7562
 * backport --zero-fill-buffers cli option (James M Snell)
   #5745
* build:
  * add Intel Vtune profiling support (Chunyang Dai)
    #5527
* repl:
  * copying tabs shouldn't trigger completion (Eugene Obrezkov)
    #5958
* src:
  * add node::FreeEnvironment public API (Cheng Zhao)
    #3098
* test:
  * run v8 tests from node tree (Bryon Leung)
    #4704
* V8:
  * Add post mortem data to improve object inspection and function's
    context variables inspection (Fedor Indutny)
    #3779

Semver Patch:

* **buffer**:
  * ignore negative allocation lengths (Anna Henningsen)
    #7562
* **crypto**:
  * update root certificates (Ben Noordhuis)
    #7363
* **libuv**:
  * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    #6796
  * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé)
    #5994
* **npm**:
  * upgrade to 2.15.9 (Kat Marchán)
    #7692
MylesBorins pushed a commit that referenced this pull request Aug 16, 2016
Notable Changes:

Semver Minor:

* buffer:
 * backport new buffer constructor APIs to v4.x
   (Сковорода Никита Андреевич)
   #7562
 * backport --zero-fill-buffers cli option (James M Snell)
   #5745
* build:
  * add Intel Vtune profiling support (Chunyang Dai)
    #5527
* repl:
  * copying tabs shouldn't trigger completion (Eugene Obrezkov)
    #5958
* src:
  * add node::FreeEnvironment public API (Cheng Zhao)
    #3098
* test:
  * run v8 tests from node tree (Bryon Leung)
    #4704
* V8:
  * Add post mortem data to improve object inspection and function's
    context variables inspection (Fedor Indutny)
    #3779

Semver Patch:

* **buffer**:
  * ignore negative allocation lengths (Anna Henningsen)
    #7562
* **crypto**:
  * update root certificates (Ben Noordhuis)
    #7363
* **libuv**:
  * upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    #6796
  * upgrade libuv to 1.9.0 (Saúl Ibarra Corretgé)
    #5994
* **npm**:
  * upgrade to 2.15.9 (Kat Marchán)
    #7692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet