Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5.11.0 proposal #6322

Closed
wants to merge 90 commits into from
Closed

V5.11.0 proposal #6322

wants to merge 90 commits into from

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Apr 21, 2016

Node.js ChangeLog

2016-04-21, Version 5.11.0 (Stable), @thealphanerd

Notable Changes

  • Buffer:
    • Buffer.prototype.compare can now compare sub-ranges of two Buffers. (James M Snell) #5880
  • deps:
    • update to http-parser 2.7.0 (Fedor Indutny) #6279
    • update ESLint to 2.7.0 (silverwind) #6132
  • net:
    • adds support for passing DNS lookup hints to createConnection() (Colin Ihrig) #6000
  • node:
    • Make the builtin libraries available for the --eval and --print CLI options (Anna Henningsen) #6207
  • npm:
    • upgrade npm to 3.8.6 (Kat Marchán) #6153
  • repl:
    • Pressing enter in the repl will repeat the last command by default if no input has been received. This behaviour was in node previously and was not removed intentionally. (Rich Trott) #6090
  • src:
    • add SIGINFO to supported signals (James Reggio) #6093
  • streams:
    • Fix a regression that caused by net streams requesting multiple chunks synchronously when combined with cork/uncork (Matteo Collina) #6164
  • zlib:
    • The flushing flag is now configurable allowing for decompression of partial data (Anna Henningsen) #6069

Commits

  • [85cb9bb31d] - assert: respect assert.doesNotThrow message. (Ilya Shaisultanov) #2407
  • [5807f9d378] - benchmark: add module loader benchmark parameter (Brian White) #5172
  • [24ec70149c] - (SEMVER-MINOR) buffer: add Buffer.prototype.compare by offset (James M Snell) #5880
  • [d44540f5af] - buffer: standardize array index check (Trevor Norris) #6084
  • [68cf6a5e6a] - build: fix make tar-headers for Linux (Gibson Fahnestock) #5978
  • [95e9c0643a] - build: allow test-ci to run tests in parallel (Johan Bergström) #6208
  • [a5f8d0c6ef] - build: remove -f{data,function}-sections flags (Ben Noordhuis) #6077
  • [2e6e2d6511] - child_process: add nullptr checks after allocs (Anna Henningsen) #6256
  • [5c9dddf66f] - (SEMVER-MINOR) debugger: run last command on presssing enter (Rich Trott) #6090
  • [b7dd451fef] - deps: update to http-parser 2.7.0 (Fedor Indutny) #6279
  • [f8c0ab98ae] - deps: floating fix for npm's test-node script (Kat Marchán) #6153
  • [1d669aba06] - deps: upgrade npm to 3.8.6 (Kat Marchán) #6153
  • [a7104e4516] - deps: cherry-pick 1383d00 from v8 upstream (Fedor Indutny) #6179
  • [632e6b9617] - deps: backport 125ac66 from v8 upstream (Myles Borins) #6086
  • [5874502cba] - doc: git mv to .md (Robert Jefe Lindstaedt) #4747
  • [02a84e20ef] - doc: add full example for zlib.flush() (Anna Henningsen) #6172
  • [9f9371bd61] - doc: note that zlib.flush acts after pending writes (Anna Henningsen) #6172
  • [b74ddea66e] - doc: fix broken references (Alexander Gromnitsky) #6100
  • [b8ae1b86d4] - doc: path.format provide more examples (John Eversole) #5838
  • [91001d33cf] - doc: replace functions with arrow functions (abouthiroppy) #6203
  • [038801d551] - doc: DCO anchor that doesn't change (William Kapke) #6257
  • [5bf8d1a9bf] - doc: fix http response event, Agent#getName (Matthew Douglass) #5993
  • [ea8fe043ae] - doc: document intention and dangers of fs module Buffer API (Nikolai Vavilov) #6020
  • [5c4395bc1b] - doc: explain differences in console.assert between node and browsers (James M Snell) #6169
  • [90eb765c51] - doc: native module reloading is not supported (Bryan English) #6168
  • [bb97de0c04] - doc: clarify fs.watch() and inodes on linux, os x (Joran Dirk Greef) #6099
  • [1796e49546] - doc: add domain postmortem (Trevor Norris) #6159
  • [02bf4599db] - doc: add stefanmb to collaborators (Stefan Budeanu) #6227
  • [4a2b53a002] - doc: add iWuzHere to collaborators (Imran Iqbal) #6226
  • [9d3317a327] - doc: add santigimeno to collaborators (Santiago Gimeno) #6225
  • [33647030d2] - doc: add addaleax to collaborators (Anna Henningsen) #6224
  • [6bc3bde47e] - doc: fix incorrect references in buffer docs (Amery) #6194
  • [b26fea1595] - doc: add copy about how to curl SHA256.txt (Myles Borins) #6120
  • [daaad47099] - doc: clarification for maxBuffer and Unicode output (James M Snell) #6030
  • [5e6915f374] - doc: describe child.kill() pitfalls on linux (Robert Jefe Lindstaedt) #2098
  • [a40d0e8f9d] - doc: fix scrolling on iOS devices (Luigi Pinca) #5878
  • [a81fca4f99] - doc: add topic - event loop, timers, nextTick() (Jeff Harris) #4936
  • [440d1172fd] - doc: add example using algorithms not directly exposed (Brad Hill) #6108
  • [96ad5c5303] - doc: update openssl LICENSE using license-builder.sh (Steven R. Loomis) #6065
  • [07829b0bc9] - doc: simple doc typo fix (Brendon Pierson) #6041
  • [bc0ee06226] - doc: note about Android support (Rich Trott) #6040
  • [60a73a2ed2] - doc: fix a typo in 5.10.1's changelog (Vladimir Varankin) #6076
  • [90aabb9b8a] - gitignore: adding .vs/ directory to .gitignore (Mike Kaufman) #6070
  • [93f91c60af] - gitignore: ignore VS 2015 *.VC.opendb files (Mike Kaufman) #6070
  • [d9cd449aa7] - http: disallow sending obviously invalid status codes (Brian White) #6291
  • [f6969a1608] - http: skip body and next message of CONNECT res (Fedor Indutny) #6279
  • [8ccfb87e1a] - http: unref socket timer on parser execute (Fedor Indutny) #6286
  • [d4abca5b27] - lib: remove bootstrap global context indirection (Jeremiah Senkpiel) #5881
  • [90c12a969c] - lib,test,tools: alignment on variable assignments (Rich Trott) #6242
  • [36c58da315] - net: replace defineGetter with defineProperty (Fedor Indutny) #6284
  • [6d9c0c9aa7] - (SEMVER-MINOR) net: support DNS hints in createConnection() (Colin Ihrig) #6000
  • [87e0734135] - (SEMVER-MINOR) node: make builtin libs available for --eval (Anna Henningsen) #6207
  • [fc89d17656] - path: fixing a test that breaks on some machines. (Mike Kaufman) #6067
  • [fbb0a06080] - process: fix incorrect usage of assert.fail() (Rich Trott) #6211
  • [40945e01c3] - (SEMVER-MINOR) repl: keep the built-in modules non-enumerable (Anna Henningsen) #6207
  • [2254f1a175] - repl: refactor repl.js (Rich Trott) #6071
  • [9f2dc70081] - (SEMVER-MINOR) src: add SIGINFO to supported signals (James Reggio) #6093
  • [fbc99ba4f1] - src: add missing 'inline' keywords (Ben Noordhuis) #6056
  • [20bb92f5c8] - src: use size_t for http parser array size fields (Ben Noordhuis) #5969
  • [2fd8be2dbe] - src: replace ARRAY_SIZE with typesafe arraysize (Ben Noordhuis) #5969
  • [4392b4aee0] - stream: Fix readableState.awaitDrain mechanism (Anna Henningsen) #6023
  • [052d87c167] - stream_base: expose bytesRead getter (Fedor Indutny) #6284
  • [f69416c06e] - streams: support unlimited synchronous cork/uncork cycles (Matteo Collina) #6164
  • [3bacd1989b] - test: add zlib close-after-error regression test (Anna Henningsen) #6270
  • [033b21bc78] - test: move more tests from sequential to parallel (Santiago Gimeno) #6187
  • [df93d6bfd2] - test: assert - fixed error messages to match the tests (surya panikkal) #6241
  • [1ef18bd038] - test: add test for responses to HTTP CONNECT req (Josh Leder) #6279
  • [8779967d4b] - test: move debugger tests to sequential (Rich Trott) #6205
  • [9293946dd6] - test: move some test from sequential to parallel (Santiago Gimeno) #6087
  • [b0ba16f966] - test: move the debugger tests back to parallel (Santiago Gimeno) #6246
  • [8077b899f4] - test: fix issues for ESLint 2.7.0 (silverwind) #6132
  • [1af0e4499c] - test: fix flaky test-http-set-timeout-server (Santiago Gimeno) #6248
  • [68c32833c6] - test: fix test-net-settimeout flakiness (Santiago Gimeno) #6166
  • [a38b614ae9] - test: fix flaky test-child-process-fork-net (Rich Trott) #6138
  • [476535cc0e] - test: fix flaky test-http-client-abort (Rich Trott) #6124
  • [6bb7999bd6] - test: refactor test-file-write-stream3 (Rich Trott) #6050
  • [a27e95231e] - test: enforce strict mode for test-domain-crypto (Rich Trott) #6047
  • [8da4bad1c9] - test: fix pummel test failures (Rich Trott) #6012
  • [fb2a9784a3] - test,tools: enable linting for undefined vars (Rich Trott) #6255
  • [01d4522763] - test,vm: enable strict mode for vm tests (Rich Trott) #6209
  • [73eac79138] - tools: lint rule for assert.fail() (Rich Trott) #6261
  • [8877703fc4] - tools: enable linting for v8_prof_processor.js (Rich Trott) #6262
  • [68925360ee] - tools: move message listener to worker objects (Brian White) #6212
  • [713f6ff67a] - tools: improve js linter (Brian White) #5638
  • [7ea5e43b98] - tools: lint for alignment of variable assignments (Rich Trott) #6242
  • [3ce59abb35] - tools: update ESLint to 2.7.0 (silverwind) #6132
  • [fb646309e2] - tools: fix license-builder.sh again for ICU (Steven R. Loomis) #6068
  • [fabc33a075] - tools: remove simplejson dependency (Sakthipriyan Vairamani) #6101
  • [0658632c08] - tools,doc: parse types in braces everywhere (Alexander Makarenko) #5329
  • [69eb4a6834] - tools,doc: fix json for grouped optional params (firedfox) #5977
  • [a2dd848764] - tools,doc: fix incomplete json produced by doctool (firedfox) #5966
  • [4f6f59977a] - zlib: fix use after null when calling .close (James Lal) #5982
  • [2ac14ee81f] - (SEMVER-MINOR) zlib: Make the finish flush flag configurable (Anna Henningsen) #6069
  • [3a5dd024d3] - (SEMVER-MINOR) zlib: detect gzip files when using unzip* (Anna Henningsen) #5884
  • [61167c3e23] - zlib: fix gzip member head/buffer boundary issue (Anna Henningsen) #5973

Trott and others added 26 commits April 20, 2016 16:24
A handful of tests in `test/pummel` were failing due to undefined
variables.

The tests in pummel are not run in CI or otherwise exercised regularly
so these failures can go unnoticed for a long time.

PR-URL: #6012
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
The BaseObject constructor and destructor should not have external
linkage because BaseObject is a header-only construct.  Add the
necessary 'inline' keywords.

PR-URL: #6056
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #6040
Refs: #6035
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
The last change to this test landed before a nit about strict mode was
addressed, so this change addresses that.

PR-URL: #6047
Refs: #6017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
We don't link with `--gc-sections` because it's unreliable with some
toolchains, so all these flags do is make the compiler generate slightly
worse code.  Drop them.

Refs: #6056
PR-URL: #6077
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
decipher.setAuthPadding canged to decipher.setAutoPadding

PR-URL: #6041
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
* due to: openssl bump in 1f43478

PR-URL: #6065
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
As requested in #5221

Original commit message:

  fix debug command processor wrt restart frame.

  R=jkummerow@chromium.org
  BUG=v8:4757
  LOG=N

  Review URL: https://codereview.chromium.org/1700693002

  Cr-Commit-Position: refs/heads/master@{#33983}

PR-URL: #6086
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
* use common.mustCall() to verify all tests have run
* eliminate unneeded removeTestFile()
* eliminate unneeded var leaking into global scope
* var -> const
* remove instance of let

PR-URL: #6050
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #6108
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
ParseArrayIndex() was requesting a Uint32Value(), but assigning it to an
in32_t. This caused slight differences in error message reported in edge
cases of argument parsing. Fixed by getting the IntegerValue() before
checking if the value is < 0. Added test of API that was affected.

PR-URL: #6084
Reviewed-By: James M Snell <jasnell@gmail.com>
Adds a new topic that provides an overview of the event loop, timers, and
`process.nextTick()` that is based upon a NodeSource "Need to Node" presentation
hosted by @trevnorris: Event Scheduling and the Node.js Event
Loop (https://nodesource.com/resources).

PR-URL: #4936
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Calvin W. Metcalf <calvin.metcalf@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
There is some unnecessary logic in repl.js. Remove it.

PR-URL: #6071
Reviewed-By: James M Snell <jasnell@gmail.com>
A win32-only test was verifying that path.win32._makeLong('C:')
would return the current working directory.  This would only work if
current working directory was also on the C: device.  Fix is to grab
the device letter for current working directory, and pass that to
_makeLong().

PR-URL: #6067
Reviewed-By: Trott - Rich Trott <rtrott@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes an issue that prevented scrolling from going past large code
blocks on iOS devices. Also fixes a few minor styling issues that
came up in the discussion.

Fixes: #5861
PR-URL: #5878
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstädt <robert.lindstaedt@gmail.com>
Doc tool produces incomplete json when it meets unordered lists that
directly following a heading. Add a default case to processList function
to handle the lists.

PR-URL: #5966
Fixes: #1545
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Current tools/doc/json.js only supports one bracket style for optional
params methodName(param0[,param1],param2). Add support to other styles
such as methodName(param0,[param1,]param2) or
methodName(param0[,param1,param2]) or
methodName(param0[,param1[,param2]]).

PR-URL: #5977
Fixes: #5976
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This commit refines the documentation around child.kill(), where kill
attempts against shells will lead to unexpected results. Namely, on
linux the child process of a child process will not terminate, when
its parent gets terminated. This is different across the the
platforms.

PR-URL: #2098
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Closes: #2098
Clarify caveats on `maxBuffer` with regards to Unicode output.

Refs: #1901
PR-URL: #6030
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Currently we include instructions on how to check the sha of a
downloaded tar-ball, but do not include instruction on how to
get the `SHA256.txt` file. This has led to confusion with people
thinking that the SHA256.txt is included in that tarball.

This commit includes instructions on how to use curl to download the
`SHA256.txt` prior to the instructions on how to verify the sha.

Refs: nodejs/help#113
Refs: nodejs/help#137
PR-URL: #6120
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
In 6899094 (#2325),
the conditions for increasing `readableState.awaitDrain` when
writing to a piping destination returns false were changed so
that they could not actually be met, effectively leaving
`readableState.awaitDrain` with a constant value of 0.

This patch changes the conditions to testing whether the
stream for which `.write()` returned false is still a piping
destination, which was likely the intention of the original
patch.

Fixes: #5820
Fixes: #5257
PR-URL: #6023
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
As Node.js expects either Python 2.6 or 2.7 installed to work properly,
simplejson module is no longer necessary. It was included in Python 2.6
as the json module.

PR-URL: #6101
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reduce client connections from 10 to 4 in a test that is causing issues
on Raspberry Pi 2 devices in CI.

Fixes: #5122
PR-URL: #6138
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Original commit message:

    tools: fix tickprocessor Cpp symbols on mac

    Despite man page documentation:

        -f Display the symbol table of a dynamic library flat (as one
           file not separate modules).

    `nm` on mac treats `-f` as a shorthand for `-format`. The `-f` argument
    does not seem to be required, so just remove it completely.

    (For `-format` documentation - see `nm --help` on mac).

    BUG=

    Review URL: https://codereview.chromium.org/1840633002

    Cr-Commit-Position: refs/heads/master@{#35445}

Fix: #5903
PR-URL: #6179
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
net streams can request multiple chunks to be written in a synchronous
fashion. If this is combined with cork/uncork, en error is currently
thrown because of a regression introduced in:
89aeab9
(#4354).

Fixes: #6154
PR-URL: #6164
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mathias Buus <mathiasbuus@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins added meta Issues and PRs related to the general management of the project. v5.x labels Apr 21, 2016
@MylesBorins MylesBorins mentioned this pull request Apr 21, 2016
addaleax and others added 9 commits April 21, 2016 08:38
Up to now, `Z_FINISH` was always the flushing flag that was used
for the last chunk of input data. This patch makes this choice
configurable so that advanced users can perform e.g. decompression of
partial data using `Z_SYNC_FLUSH`, if that suits their needs.

Add tests to make sure that an error is thrown upon encountering
invalid `flush` or `finishFlush` flags.

Fixes: #5761
PR-URL: #6069
Reviewed-By: James M Snell <jasnell@gmail.com>
Make the builtin libraries available for the `--eval` and
`--print` CLI options, using the same mechanism that the
REPL uses.

This renders workarounds like `node -e 'require("fs").doStuff()'`
unnecessary.

As part of this, the list of builtin modules and the code for
adding the corresponding properties to the target context is moved
to `internal/module.js`, and the previously missing `repl` entry
is added.

PR-URL: #6207
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Make sure that the built-in modules in the repl stay non-enumerable.
Previously, they would pop up as enumerable properties of the global
object after having been accessed for the first time.

PR-URL: #6207
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Describe that `zlib.flush()` may wait for pending writes and
until output is being read from the stream.

Fixes: #3782
PR-URL: #6172
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Add a full example using `zlib.flush()` for the common use
case of writing partial compressed HTTP output to the client.

PR-URL: #6172
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
* doc: rename .markdown references in content
* doc: rename to .md in tools
* doc: rename to .md in CONTRIBUTING.md

PR-URL: #4747
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: techjeffharris
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #6291
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

PR-URL: #5982
Fixes: #6034
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Add a regression test based on the report in
#6034.

PR-URL: #6270
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins force-pushed the v5.11.0-proposal branch 2 times, most recently from f6d26ff to fde4234 Compare April 21, 2016 15:44
Buffer:
  * Buffer.prototype.compare can now compare sub-ranges of two Buffers
   (James M Snell) #5880

deps:
  * update to http-parser 2.7.0
    (Fedor Indutny) #6279
  * update ESLint to 2.7.0
    (silverwind) #6132

net:
  * adds support for passing DNS lookup hints to createConnection()
    (Colin Ihrig) #6000

node:
  * Make the builtin libraries available for the --eval and --print
    CLI options
    (Anna Henningsen) #6207

npm:
  * upgrade npm to 3.8.6
    (Kat Marchán) #6153

repl:
  * Pressing enter in the repl will repeat the last command by default
    if no input has been received. This behavior was in node
    previously and was not removed intentionally.
    (Rich Trott) #6090

src:
  * add SIGINFO to supported signals
    (James Reggio) #6093

streams:
  * Fix a regression that caused by net streams requesting multiple
    chunks synchronously when combined with cork/uncork
    (Matteo Collina) #6164

zlib:
  * The flushing flag is now configurable allowing for decompression
    of partial data
    (Anna Henningsen) #6069
@MylesBorins
Copy link
Contributor Author

Ended up dropping #6192 as a regression was found in the v6 rc

one more round of testing

ci: https://ci.nodejs.org/job/node-test-pull-request/2357/
smoke-testing: https://ci.nodejs.org/view/Node.js-citgm/job/thealphanerd-smoker/211/
rc: https://nodejs.org/download/rc/v5.11.0-rc.2/

@MylesBorins
Copy link
Contributor Author

Everything is looking good in testing. i'd like a few LGTM's from @nodejs/collaborators

I've started the release build, and assuming there are no problems with it I hope to have this out in the wild by 2pm PST.

@jasnell
Copy link
Member

jasnell commented Apr 21, 2016

LGTM if tests are good.

MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
Buffer:
  * Buffer.prototype.compare can now compare sub-ranges of two Buffers
   (James M Snell) #5880

deps:
  * update to http-parser 2.7.0
    (Fedor Indutny) #6279
  * update ESLint to 2.7.0
    (silverwind) #6132

net:
  * adds support for passing DNS lookup hints to createConnection()
    (Colin Ihrig) #6000

node:
  * Make the builtin libraries available for the --eval and --print
    CLI options
    (Anna Henningsen) #6207

npm:
  * upgrade npm to 3.8.6
    (Kat Marchán) #6153

repl:
  * Pressing enter in the repl will repeat the last command by default
    if no input has been received. This behaviour was in node
    previously and was not removed intentionally.
    (Rich Trott) #6090

src:
  * add SIGINFO to supported signals
    (James Reggio) #6093

streams:
  * Fix a regression that caused by net streams requesting multiple
    chunks synchronously when combined with cork/uncork
    (Matteo Collina) #6164

zlib:
  * The flushing flag is now configurable allowing for decompression
    of partial data
    (Anna Henningsen) #6069

PR-URL: #6322
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
Buffer:
  * Buffer.prototype.compare can now compare sub-ranges of two Buffers
   (James M Snell) #5880

deps:
  * update to http-parser 2.7.0
    (Fedor Indutny) #6279
  * update ESLint to 2.7.0
    (silverwind) #6132

net:
  * adds support for passing DNS lookup hints to createConnection()
    (Colin Ihrig) #6000

node:
  * Make the builtin libraries available for the --eval and --print
    CLI options
    (Anna Henningsen) #6207

npm:
  * upgrade npm to 3.8.6
    (Kat Marchán) #6153

repl:
  * Pressing enter in the repl will repeat the last command by default
    if no input has been received. This behaviour was in node
    previously and was not removed intentionally.
    (Rich Trott) #6090

src:
  * add SIGINFO to supported signals
    (James Reggio) #6093

streams:
  * Fix a regression that caused by net streams requesting multiple
    chunks synchronously when combined with cork/uncork
    (Matteo Collina) #6164

zlib:
  * The flushing flag is now configurable allowing for decompression
    of partial data
    (Anna Henningsen) #6069

PR-URL: #6322
@MylesBorins
Copy link
Contributor Author

landed in a40d0e8...ca215b9

@vsemozhetbyt
Copy link
Contributor

chl

@MylesBorins
Copy link
Contributor Author

IT HAS HAPPENED!

/cc @nodejs/ctc

@MylesBorins
Copy link
Contributor Author

@vsemozhetbyt PR in to potentially fix this #6337

joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
Buffer:
  * Buffer.prototype.compare can now compare sub-ranges of two Buffers
   (James M Snell) nodejs#5880

deps:
  * update to http-parser 2.7.0
    (Fedor Indutny) nodejs#6279
  * update ESLint to 2.7.0
    (silverwind) nodejs#6132

net:
  * adds support for passing DNS lookup hints to createConnection()
    (Colin Ihrig) nodejs#6000

node:
  * Make the builtin libraries available for the --eval and --print
    CLI options
    (Anna Henningsen) nodejs#6207

npm:
  * upgrade npm to 3.8.6
    (Kat Marchán) nodejs#6153

repl:
  * Pressing enter in the repl will repeat the last command by default
    if no input has been received. This behaviour was in node
    previously and was not removed intentionally.
    (Rich Trott) nodejs#6090

src:
  * add SIGINFO to supported signals
    (James Reggio) nodejs#6093

streams:
  * Fix a regression that caused by net streams requesting multiple
    chunks synchronously when combined with cork/uncork
    (Matteo Collina) nodejs#6164

zlib:
  * The flushing flag is now configurable allowing for decompression
    of partial data
    (Anna Henningsen) nodejs#6069

PR-URL: nodejs#6322
jasnell pushed a commit that referenced this pull request Apr 26, 2016
Buffer:
  * Buffer.prototype.compare can now compare sub-ranges of two Buffers
   (James M Snell) #5880

deps:
  * update to http-parser 2.7.0
    (Fedor Indutny) #6279
  * update ESLint to 2.7.0
    (silverwind) #6132

net:
  * adds support for passing DNS lookup hints to createConnection()
    (Colin Ihrig) #6000

node:
  * Make the builtin libraries available for the --eval and --print
    CLI options
    (Anna Henningsen) #6207

npm:
  * upgrade npm to 3.8.6
    (Kat Marchán) #6153

repl:
  * Pressing enter in the repl will repeat the last command by default
    if no input has been received. This behaviour was in node
    previously and was not removed intentionally.
    (Rich Trott) #6090

src:
  * add SIGINFO to supported signals
    (James Reggio) #6093

streams:
  * Fix a regression that caused by net streams requesting multiple
    chunks synchronously when combined with cork/uncork
    (Matteo Collina) #6164

zlib:
  * The flushing flag is now configurable allowing for decompression
    of partial data
    (Anna Henningsen) #6069

PR-URL: #6322
@targos targos deleted the v5.11.0-proposal branch April 27, 2016 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.