Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make pull request template more concise #7239

Closed
wants to merge 1 commit into from
Closed

doc: make pull request template more concise #7239

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 8, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc meta

Description of change

@Trott Trott added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Jun 8, 2016
@jasnell
Copy link
Member

jasnell commented Jun 9, 2016

Automatic rubber stamp LGTM

@benjamingr
Copy link
Member

LGTM

3 similar comments
@targos
Copy link
Member

targos commented Jun 9, 2016

LGTM

@mscdex
Copy link
Contributor

mscdex commented Jun 9, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Jun 9, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jun 11, 2016
@Trott
doc: make pull request template more concise
47b9b14 
PR-URL: nodejs#7239
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jun 11, 2016

Landed in 47b9b14

@Trott Trott closed this Jun 11, 2016
evanlucas pushed a commit that referenced this pull request Jun 16, 2016
@Trott @evanlucas
doc: make pull request template more concise
b5e44df 
PR-URL: #7239
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
@evanlucas evanlucas mentioned this pull request Jun 16, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
@Trott Trott deleted the shortertemplate branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @jasnell @benjamingr @targos @mscdex @cjihrig @MylesBorins