Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.4.7 proposal #7395

Merged
merged 92 commits into from
Jun 28, 2016
Merged

v4.4.7 proposal #7395

merged 92 commits into from
Jun 28, 2016

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Jun 24, 2016

2016-06-28, Version 4.4.7 'Argon' (LTS), @thealphanerd

This LTS release comes with 89 commits. This includes 46 commits that are docs related, 11 commits that are test related, 8 commits that are build related, and 4 commits that are benchmark related.

Notable Changes

  • debugger:
    • All properties of an array (aside from length) can now be printed in the repl (cjihrig) #6448
  • npm:
    • Upgrade npm to 2.15.8 (Rebecca Turner) #7412
  • stream:
    • Fix for a bug that became more prevalent with the stream changes that landed in v4.4.5. (Anna Henningsen) #7160
  • V8:
    • Fix for a bug in crankshaft that was causing crashes on arm64 (Myles Borins) #7442
    • Add missing classes to postmortem info such as JSMap and JSSet (evan.lucas) #3792

Commits

  • [87cdb83a96] - benchmark: merge url.js with url-resolve.js (Andreas Madsen) #5177
  • [921e8568d5] - benchmark: move misc to categorized directories (Andreas Madsen) #5177
  • [c189eec14e] - benchmark: fix configuation parameters (Andreas Madsen) #5177
  • [58ad451f0b] - benchmark: move string-decoder to its own category (Andreas Madsen) #5177
  • [a01caa3166] - build: don't compile with -B, redux (Ben Noordhuis) #6650
  • [37606caeaf] - build: don't compile with -B (Ben Noordhuis) #6393
  • [64fb7a1929] - build: update android-configure script for npm (Robert Chiras) #6349
  • [43ce6fc8d2] - build: fix DESTCPU detection for binary target (Richard Lau) #6310
  • [6dfe7aeed5] - cares: Support malloc(0) scenarios for AIX (Gireesh Punathil) #6305
  • [2389006720] - debugger: display array contents in repl (cjihrig) #6448
  • [1c6809ce75] - debugger: introduce exec method for debugger (Jackson Tian)
  • [200b3ca9ed] - deps: upgrade npm in LTS to 2.15.8 (Rebecca Turner) #7412
  • [49921e8819] - deps: backport 102e3e87e7 from V8 upstream (Myles Borins) #7442
  • [de00f91041] - deps: backport bc2e393 from v8 upstream (evan.lucas) #3792
  • [1549899531] - dgram,test: add addMembership/dropMembership tests (Rich Trott) #6753
  • [0ba3c2ca66] - doc: fix layout problem in v4 changelog (Myles Borins) #7394
  • [98469ad84d] - doc: correct args for cluster message event (Colin Ihrig) #7297
  • [67863f110b] - doc: update licenses (Myles Borins) #7127
  • [c31eaad42d] - doc: clarify buffer class (Steve Mao) #6914
  • [e0dd476fe5] - doc: fix typos in timers topic to aid readability (Kevin Donahue) #6916
  • [a8391bc9fc] - doc: add jhamhader to collaborators (Yuval Brik) #6946
  • [22ca7b877b] - doc: add @othiym23 to list of collaborators (Forrest L Norvell) #6945
  • [2c3c4e5819] - doc: reference list of language-specific globals (Anna Henningsen) #6900
  • [5a1a0b5ed1] - doc: make the api doc print-friendly (Marian) #6748
  • [03db88e012] - doc: add bengl to collaborators (Bryan English) #6921
  • [fbf95dde94] - doc: Update DCO to v1.1 (William Kapke) #6353
  • [f23a9c39c0] - doc: fix typo in Error.captureStackTrace (Mohsen) #6811
  • [30ab6a890c] - doc: fix name to match git log (Robert Jefe Lindstaedt) #6880
  • [2b0f40ca16] - doc: add note for fs.watch virtualized env (Robert Jefe Lindstaedt) #6809
  • [3b461870be] - doc: Backport ee.once doc clarifications to 4.x. (Lance Ball) #7103
  • [eadb7e5b20] - doc: subdivide TOC, add auxiliary links (Jeremiah Senkpiel) #6167
  • [107839c5dd] - doc: no Node.js(1) (Jeremiah Senkpiel) #6167
  • [401325f9e2] - doc: better example & synopsis (Jeremiah Senkpiel) #6167
  • [c654184f28] - doc: remove link to Sign in crypto.md (Kirill Fomichev) #6812
  • [3e9288e466] - doc: fix exec example in child_process (Evan Lucas) #6660
  • [3d820e45b4] - doc: "a" -> "an" in api/documentation.md (Anchika Agarwal) #6689
  • [352496daa2] - doc: move the readme newcomers section (Jeremiah Senkpiel) #6681
  • [ac6b921ce5] - doc: mention existence/purpose of module wrapper (Matt Harrison) #6433
  • [97d1fc0fc6] - doc: improve onboarding-extras.md formatting (Jeremiah Senkpiel) #6548
  • [c9b144ddd4] - doc: linkify remaining references to fs.Stats object (Kevin Donahue) #6485
  • [d909c25a33] - doc: fix the lint of an example in cluster.md (yorkie) #6516
  • [21d02f460f] - doc: add missing underscore for markdown italics (Kevin Donahue) #6529
  • [18ecc779bb] - doc: ensure consistent grammar in node.1 file (justshiv) #6426
  • [52d9e7b61d] - doc: fix a typo in __dirname section (William Luo) #6473
  • [de20235235] - doc: remove all scrollbar styling (Claudio Rodriguez) #6479
  • [a6f45b4eda] - doc: Remove extra space in REPL example (Juan) #6447
  • [feda15b2b8] - doc: update build instructions for OS X (Rich Trott) #6309
  • [3d1a3e4a30] - doc: change references to Stable to Current (Myles Borins) #6318
  • [e28598b1ef] - doc: update authors (James M Snell) #6373
  • [0f3a94acbd] - doc: add JacksonTian to collaborators (Jackson Tian) #6388
  • [d7d54c8fd2] - doc: add Minqi Pan to collaborators (Minqi Pan) #6387
  • [83721c6fd2] - doc: add eljefedelrodeodeljefe to collaborators (Robert Jefe Lindstaedt) #6389
  • [b112fd1b4e] - doc: add ronkorving to collaborators (ronkorving) #6385
  • [ac60d9cc86] - doc: add estliberitas to collaborators (Alexander Makarenko) #6386
  • [435cd56de5] - doc: DCO anchor that doesn't change (William Kapke) #6257
  • [7d8141dd1b] - doc: add stefanmb to collaborators (Stefan Budeanu) #6227
  • [6dfc96326d] - doc: add iWuzHere to collaborators (Imran Iqbal) #6226
  • [3dbcc73159] - doc: add santigimeno to collaborators (Santiago Gimeno) #6225
  • [ae3eb24a3d] - doc: add addaleax to collaborators (Anna Henningsen) #6224
  • [46ee7bb4ba] - doc: fix incorrect references in buffer docs (Amery) #6194
  • [e3f78eb7c1] - doc: improve rendering of v4.4.5 changelog entry (Myles Borins) #6958
  • [bac87d01d9] - gitignore: adding .vs/ directory to .gitignore (Mike Kaufman) #6070
  • [93f2314dc2] - gitignore: ignore VS 2015 *.VC.opendb files (Mike Kaufman) #6070
  • [c98aaf59bf] - http: speed up checkIsHttpToken (Jackson Tian) #4790
  • [552e25cb6b] - lib,test: update in preparation for linter update (Rich Trott) #6498
  • [aaeeec4765] - lib,test,tools: alignment on variable assignments (Rich Trott) #6869
  • [b3acbc5648] - net: replace defineGetter with defineProperty (Fedor Indutny) #6284
  • [4c1eb5bf03] - repl: create history file with mode 0600 (Carl Lei) #3394
  • [90306bb81d] - src: use size_t for http parser array size fields (Ben Noordhuis) #5969
  • [af41a63d0f] - src: replace ARRAY_SIZE with typesafe arraysize (Ben Noordhuis) #5969
  • [037291e31f] - src: make sure Utf8Value always zero-terminates (Anna Henningsen) #7101
  • [a08a0179e9] - stream: ensure awaitDrain is increased once (David Halls) #7292
  • [b73ec46dcb] - stream: reset awaitDrain after manual .resume() (Anna Henningsen) #7160
  • [55319fe798] - stream_base: expose bytesRead getter (Fedor Indutny) #6284
  • [0414d882ce] - test: fix test-net-* error code check for getaddrinfo(3) (Natanael Copa) #5099
  • [be0bb5f5fc] - test: fix unreliable known_issues test (Rich Trott) #6555
  • [ab50e82f42] - test: fix test-process-exec-argv flakiness (Santiago Gimeno) #7128
  • [4e38655d5f] - test: refactor test-tls-reuse-host-from-socket (Rich Trott) #6756
  • [1c4549a31e] - test: fix flaky test-stdout-close-catch (Santiago Gimeno) #6808
  • [3b94e31245] - test: robust handling of env for npm-test-install (Myles Borins) #6797
  • [4067cde7ee] - test: abstract skip functionality to common (Jeremiah Senkpiel) #7114
  • [8b396e3d71] - test: fix test-debugger-repl-break-in-module (Rich Trott) #6686
  • [847b29c050] - test: fix test-debugger-repl-term (Rich Trott) #6682
  • [1d68bdbe3f] - test: fix error message checks in test-module-loading (James M Snell) #5986
  • [7e739ae159] - test,tools: adjust function argument alignment (Rich Trott) #7100
  • [216486c2b6] - tools: lint for function argument alignment (Rich Trott) #7100
  • [6a76485ad7] - tools: update ESLint to 2.9.0 (Rich Trott) #6498
  • [a31153c02c] - tools: remove the minifying logic (Sakthipriyan Vairamani) #6636
  • [10bd1a73fd] - tools: fix license-builder.sh again for ICU (Steven R. Loomis) #6068
  • [0f6146c6c0] - tools: add tests for the doctool (Ian Kronquist) #6031
  • [cc3645cff3] - tools: lint for alignment of variable assignments (Rich Trott) #6869

Trott and others added 12 commits June 23, 2016 16:59
Correct alignment on variable assignments that span multiple lines in
preparation for lint rule to enforce such alignment.

PR-URL: #6869
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Enforce alignment/indentation on variable assignments that span multiple
lines.

PR-URL: #6869
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
In debugger, the usage of `repl` very ugly. I'd like there is a `p`
like gdb. So the `exec` is coming.

Usage:

```
$ ./iojs debug ~/git/node_research/server.js
< Debugger listening on port 5858
connecting to 127.0.0.1:5858 ... ok
break in /Users/jacksontian/git/node_research/server.js:1
> 1 var http = require('http');
  2
  3 http.createServer(function (req, res) {
debug> exec process.title
/Users/jacksontian/git/io.js/out/Release/iojs
debug>
```

And the `repl`:

```
debug> repl
Press Ctrl + C to leave debug repl
> process.title
'/Users/jacksontian/git/io.js/out/Release/iojs'
debug>
(^C again to quit)
```

The enter and leave debug repl is superfluous.

R-URL: #1491
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Remove extra newlines that were causing rendering problems.

PR-URL: #6958
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This will provide `bytesRead` data on consumed sockets.

Fix: #3021
PR-URL: #6284
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
`Object.prototype.__defineGetter__` is deprecated now, use
`Object.defineProperty` instead.

PR-URL: #6284
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Original commit message:

  [tools] Make gen-postmortem-metadata.py more reliable

  Instead of basing matches off of whitespace, walk the
  inheritance chain and include any classes that inherit
  from Object.

  R=machenbach@chromium.org,jkummerow@chromium.org
  NOTRY=true

  Review URL: https://codereview.chromium.org/1435643002

  Cr-Commit-Position: refs/heads/master@{#31964}

This adds some missing classes to postmortem info like
JSMap and JSSet.

PR-URL: #3792
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Set the mode bits on the history file to 0o600 instead of leaving it
unspecified, which resulted in 0o755 on Unices.

Test code mostly written by Trott:
#3392 (comment).

PR-URL: #3394
Fixes: #3392
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
The Regex implementation is not faster than ascii code compare.

the field name is shorter, the speed is faster.

benchmark result here:

https://bitbucket.org/snippets/JacksonTian/Rnbad/benchmark-result

PR-URL: #4790
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #5986
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* Test the toHTML function in html.js. Check that given valid markdown
  it produces the expected html. One test case will prevent regressions
  of #5873.
* Check that when given valid markdown toJSON produces valid JSON with
  the expected schema.
* Add doctool to the list of built in tests so it runs in CI.

PR-URL: #6031
Fixes: #5955
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rich Trott <rtrott@gmail.com>
`make binary` attempts to auto detect DESTCPU if not set, but was
assuming being on an Intel architecture.

PR-URL: #6310
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins added the meta Issues and PRs related to the general management of the project. label Jun 24, 2016
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 24, 2016
@MylesBorins MylesBorins changed the title metaV4.4.7 proposal v4.4.7 proposal Jun 24, 2016
@MylesBorins
Copy link
Contributor Author

/cc @nodejs/lts

Amery2010 and others added 13 commits June 23, 2016 17:24
PR-URL: #6194
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: #6224
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #6225
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #6226
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #6227
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
These files are created by VS 2015 and should be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This is created by vs 2015 for user & machine-specific files and should
be ignored by git.

PR-URL: #6070
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
* Modify tools/license-builder.sh to support ICU 57.1's plain text
license. (Separate issue to add ICU 57.1 in #6058)
* Update/regenerate LICENSE to include ICU 57.1's license
* Note that because the tool was rerun, the change in #6065 is already
included here.

PR-URL: #6068
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroem.nu
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #6385
PR-URL: #6389
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Also changed alias P.S.V.R to Minqi Pan.

Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
PR-URL: #6387
@Fishrock123
Copy link
Contributor

lgtm

@AndreasMadsen
Copy link
Member

@thealphanerd when will v4.5.0 with the updated async-wrap #7048 be released. I keep getting mails about it, and the only thing I can tell them is to be patient.

@Fishrock123
Copy link
Contributor

@thealphanerd We should release this next week and move towards a speedy minor... We keep holding this stuff up really really long...

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Jun 24, 2016 via email

@rvagg
Copy link
Member

rvagg commented Jun 27, 2016

this all looks pretty vanilla, if citgm is happy then I'm happy, 👍

@saghul
Copy link
Member

saghul commented Jun 27, 2016

How about #7205 ?

@jasnell
Copy link
Member

jasnell commented Jun 27, 2016

LGTM

ncopa and others added 2 commits June 27, 2016 13:30
Replace '...' as invalid hostname with '***', which will give a more
consisten error message on different systems. The hostname '...' returns
EAI_AGAIN on musl libc and EAI_NONAME on most other systems.

By changing the testcase we get same restult on all known platforms.

PR-URL: #5099
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
The current layout is breaking the release post tool.

This commit also removed erroneous entires in the main CHANGELOG for
v4.4.6 and v5.12.0.

PR-URL: #7394
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor Author

@saghul We'll be testing the update to libuv for v4.5.0

@MylesBorins
Copy link
Contributor Author

This commit backports a fix to a crankshaft bug affects arm64 systems.

Original commit message:

    [arm64] Fix jssp based spill slot accesses in Crankshaft

    Review URL: https://codereview.chromium.org/1401703003

    Cr-Commit-Position: refs/heads/master@{#31304}

Fixes: #7417
PR-URL: #7442
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor Author

/cc @nodejs/collaborators can ya'll please take a look at the changelog and ensure everything is A OK

PR-URL: #7412
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins force-pushed the v4.4.7-proposal branch 2 times, most recently from 867bcde to 45e78fa Compare June 28, 2016 20:16
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Jun 28, 2016

This LTS release comes with 89 commits. This includes 46 commits that
are docs related, 11 commits that are test related, 8 commits that are
build related, and 4 commits that are benchmark related.

Notable Changes:

- debugger:
  - All properties of an array (aside from length) can now be printed
    in the repl (cjihrig)
    #6448
- npm:
  - Upgrade npm to 2.15.8 (Rebecca Turner)
    #7412
- stream:
  - Fix for a bug that became more prevalent with the stream changes
    that landed in v4.4.5. (Anna Henningsen)
    #7160
- V8:
  - Fix for a bug in crankshaft that was causing crashes on arm64
    (Myles Borins)
    #7442
  - Add missing classes to postmortem info such as JSMap and JSSet
    (evan.lucas)
    #3792
@rmg
Copy link
Contributor

rmg commented Jun 28, 2016

looks like what one would expect from a patch release on an LTS stream 👍

@benjamingr
Copy link
Member

LGTM

@MylesBorins MylesBorins merged commit 0974fc6 into v4.x Jun 28, 2016
MylesBorins pushed a commit that referenced this pull request Jun 28, 2016
geminiyellow added a commit to ilivebox/heroku-nodejs that referenced this pull request Jul 5, 2016
geminiyellow added a commit to ilivebox/heroku-nodejs that referenced this pull request Jul 5, 2016
@MylesBorins MylesBorins deleted the v4.4.7-proposal branch July 8, 2016 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.