Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: make SyncWriteStream inherit from Writable #8830

Closed
wants to merge 2 commits into from
Closed

fs: make SyncWriteStream inherit from Writable #8830

wants to merge 2 commits into from

Commits on Sep 28, 2016

  1. fs: make SyncWriteStream inherit from Writable 

    Make the internal `SyncWriteStream` a proper `stream.Writable`
subclass. This allows for quite a bit of simplification, since
`SyncWriteStream` predates the streams2/streams3 implementations.

Fixes: nodejs#8828
    @addaleax
    addaleax committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    e1ef536 View commit details
    Browse the repository at this point in the history

  2. [squash] fix nit

    @addaleax
    addaleax committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    ecfd736 View commit details
    Browse the repository at this point in the history