crypto: return this in setAuthTag/setAAD #9398

fanatid · 2016-11-01T12:27:12Z

Checklist

make -j8 test (UNIX)
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

crypto

Description of change

Allow method chaining as with setAutoPadding and other methods.

addaleax

LGTM

addaleax · 2016-11-01T12:31:02Z

test/parallel/test-crypto-cipher-decipher.js

@@ -139,3 +139,14 @@ testCipher2(Buffer.from('0123456789abcdef'));
  assert.doesNotThrow(() => txt += decipher.final('utf-16le'));
  assert.strictEqual(txt, plaintext, 'decrypted result in utf-16le');
 }
+
+// setAutoPadding/setAuthTag/setAAD should return this


Can I suggest that you enclose this in backticks or something? Otherwise the “this” reads like a demonstrative pronoun in this sentence

@addaleax updated

@fanatid thanks!

cjihrig · 2016-11-01T12:36:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/4756/

sam-github · 2016-11-01T15:12:59Z

LGTM

mscdex · 2016-11-01T17:48:44Z

LGTM

jasnell · 2016-11-02T14:26:12Z

Docs should be updated also.

Allow method chaining as with setAutoPadding and other methods.

fanatid · 2016-11-02T17:10:27Z

@jasnell docs updated

addaleax · 2016-11-20T00:22:34Z

Landed in 6b86ecc, thanks for the PR!

Allow method chaining as with setAutoPadding and other methods. PR-URL: #9398 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <sam@strongloop.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) #9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) #9296 & #9296 * libuv: Upgrade to v1.10.1 (cjihrig) #9647 * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) #9587 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) #9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) #8610 PR-URL: #9745

This is a security release impacting Windows 10 users. Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) #9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) #9296 & #9296 * libuv: Upgrade to v1.10.1 (cjihrig) #9647 - Fixed a potential buffer overflow when writing data to console on Windows 10. (CVE-2016-9551) * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) #9587 * tls: Fixed a memory leak when writes were queued on TLS connection that was destroyed during handshake. (Fedor Indutny) #9626 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) #9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) #8610 PR-URL: #9745

This is a security release impacting Windows 10 users. Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) nodejs/node#9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) nodejs/node#9296 & nodejs/node#9296 * libuv: Upgrade to v1.10.1 (cjihrig) nodejs/node#9647 - Fixed a potential buffer overflow when writing data to console on Windows 10. (CVE-2016-9551) * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) nodejs/node#9587 * tls: Fixed a memory leak when writes were queued on TLS connection that was destroyed during handshake. (Fedor Indutny) nodejs/node#9626 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) nodejs/node#9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) nodejs/node#8610 Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

Allow method chaining as with setAutoPadding and other methods. PR-URL: #9398 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <sam@strongloop.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>

This LTS release comes with 126 commits. This includes 40 which are test related, 32 which are doc related, 12 which are build / tool related and 4 commits which are updates to dependencies. Notable Changes: * build: - support for building mips64el (nanxiongchao) #10991 * cluster: - disconnect() now returns a reference to the disconnected worker. (Sean Villars) #10019 * crypto: - ability to select cert store at runtime (Adam Majer) #8334 - Use system CAs instead of using bundled ones (Adam Majer) #8334 - The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) #9398 - adding support for OPENSSL_CONF again (Sam Roberts) #11006 - make LazyTransform compabile with Streams1 (Matteo Collina) #12380 * deps: - upgrade libuv to 1.11.0 (cjihrig) #11094 - upgrade libuv to 1.10.2 (cjihrig) #10717 - upgrade libuv to 1.10.1 (cjihrig) #9647 - upgrade libuv to 1.10.0 (cjihrig) #9267 * dns: - Implemented `{ttl: true}` for `resolve4()` and `resolve6()` (Ben Noordhuis) #9296 * process: - add NODE_NO_WARNINGS environment variable (cjihrig) #10842 * readline: - add option to stop duplicates in history (Danny Nemer) #2982 * src: - support "--" after "-e" as end-of-options (John Barboza) #10651 * tls: - new tls.TLSSocket() supports sec ctx options (Sam Roberts) #11005 - Allow obvious key/passphrase combinations. (Sam Roberts) #10294 PR-URL: #13059

Allow method chaining as with setAutoPadding and other methods. PR-URL: nodejs/node#9398 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <sam@strongloop.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>

This LTS release comes with 126 commits. This includes 40 which are test related, 32 which are doc related, 12 which are build / tool related and 4 commits which are updates to dependencies. Notable Changes: * build: - support for building mips64el (nanxiongchao) nodejs/node#10991 * cluster: - disconnect() now returns a reference to the disconnected worker. (Sean Villars) nodejs/node#10019 * crypto: - ability to select cert store at runtime (Adam Majer) nodejs/node#8334 - Use system CAs instead of using bundled ones (Adam Majer) nodejs/node#8334 - The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) nodejs/node#9398 - adding support for OPENSSL_CONF again (Sam Roberts) nodejs/node#11006 - make LazyTransform compabile with Streams1 (Matteo Collina) nodejs/node#12380 * deps: - upgrade libuv to 1.11.0 (cjihrig) nodejs/node#11094 - upgrade libuv to 1.10.2 (cjihrig) nodejs/node#10717 - upgrade libuv to 1.10.1 (cjihrig) nodejs/node#9647 - upgrade libuv to 1.10.0 (cjihrig) nodejs/node#9267 * dns: - Implemented `{ttl: true}` for `resolve4()` and `resolve6()` (Ben Noordhuis) nodejs/node#9296 * process: - add NODE_NO_WARNINGS environment variable (cjihrig) nodejs/node#10842 * readline: - add option to stop duplicates in history (Danny Nemer) nodejs/node#2982 * src: - support "--" after "-e" as end-of-options (John Barboza) nodejs/node#10651 * tls: - new tls.TLSSocket() supports sec ctx options (Sam Roberts) nodejs/node#11005 - Allow obvious key/passphrase combinations. (Sam Roberts) nodejs/node#10294 PR-URL: nodejs/node#13059

nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Nov 1, 2016

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 1, 2016

cjihrig approved these changes Nov 1, 2016

View reviewed changes

addaleax approved these changes Nov 1, 2016

View reviewed changes

fanatid force-pushed the crypto/return-this branch from 521e065 to 32a46cc Compare November 1, 2016 12:33

lpinca approved these changes Nov 1, 2016

View reviewed changes

fanatid mentioned this pull request Nov 2, 2016

[WIP] v2.0.0 (only ciphers, not hashes) browserify/cipher-base#3

Open

crypto: return this in setAuthTag/setAAD

e22693d

Allow method chaining as with setAutoPadding and other methods.

fanatid force-pushed the crypto/return-this branch from 32a46cc to e22693d Compare November 2, 2016 17:05

jasnell approved these changes Nov 3, 2016

View reviewed changes

addaleax closed this Nov 20, 2016

Fishrock123 mentioned this pull request Nov 22, 2016

v7.2.0 proposal #9745

Merged

2 tasks

gibfahn mentioned this pull request Apr 24, 2017

Potential Semver Minor Backports nodejs/Release#188

Closed

31 tasks

MylesBorins added the land-on-v6.x label May 16, 2017

MylesBorins mentioned this pull request May 23, 2017

v6.11.0 proposal #13059

Merged

fanatid deleted the crypto/return-this branch September 7, 2019 14:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

crypto: return this in setAuthTag/setAAD #9398

crypto: return this in setAuthTag/setAAD #9398

fanatid commented Nov 1, 2016 •

edited

Loading

addaleax left a comment

addaleax Nov 1, 2016 •

edited

Loading

fanatid Nov 1, 2016

addaleax Nov 1, 2016

cjihrig commented Nov 1, 2016

sam-github commented Nov 1, 2016

mscdex commented Nov 1, 2016

jasnell commented Nov 2, 2016

fanatid commented Nov 2, 2016

addaleax commented Nov 20, 2016

crypto: return this in setAuthTag/setAAD #9398

crypto: return this in setAuthTag/setAAD #9398

Conversation

fanatid commented Nov 1, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

addaleax left a comment

Choose a reason for hiding this comment

addaleax Nov 1, 2016 • edited Loading

Choose a reason for hiding this comment

fanatid Nov 1, 2016

Choose a reason for hiding this comment

addaleax Nov 1, 2016

Choose a reason for hiding this comment

cjihrig commented Nov 1, 2016

sam-github commented Nov 1, 2016

mscdex commented Nov 1, 2016

jasnell commented Nov 2, 2016

fanatid commented Nov 2, 2016

addaleax commented Nov 20, 2016

fanatid commented Nov 1, 2016 •

edited

Loading

addaleax Nov 1, 2016 •

edited

Loading