-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create NavItem
Component
#5911
Comments
NavbarItem
ComponentNavbarItem
and FooterItem
Components
NavbarItem
and FooterItem
ComponentsNavItem
Component
Can I work on this issue? |
yes, go for it! thanks @shaikahmadnawaz |
Thank you @bmuenzenmeyer |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Yes I did, how can I run without installing dependencies 😗 |
It's a common question to do. I would recommend you to open an issue so that we don't pollute this one. I can only tell you that the whole process works fine on Linux, macOS and Windows because we have CI for that. Open a new issue reporting this problem and don't forget to attach your Node.js version and NPM version. |
Okay 👍 |
#5921 issues solved, now I am good to go. 😊 |
@ovflowd I noticed this issue was moved back to Ready status and no one was assigned to it. So I went ahead and made a PR |
Create a
NavItem
component using the new figma design (direct link to Nav) and here is Footer.This component is a link with additional styling for focus states, and an indicator if the href is an external link. This one component will be used for both the
Navbar
(green accents) and theFooter
(grey accents) in future issues.Before You Start...
Details
❓ Not sure where to start breaking down the figma? Read this short guide
NavItem
within thesections
directory that contains all the new code.sections
may not exist yetGreen/600
per the figma.components/sections/NavItem/index.stories.tsx
which exercises each of the component's states.href
host compared to the current host to determine if the link is external. If it is, renderarrow-up-right
icon from the hero icons dependency. This only applies fortype
===nav
Suggested props include:
label
(string):Learn
in the figmahref
(typeof next/link
)type
(enum,nav
|footer
)There are 8 Navbar states to capture within styles and stories:
There are 4 footer states to capture within styles and stories:
The text was updated successfully, but these errors were encountered: