Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create NavItem Component #5911

Closed
bmuenzenmeyer opened this issue Sep 29, 2023 · 11 comments
Closed

Create NavItem Component #5911

bmuenzenmeyer opened this issue Sep 29, 2023 · 11 comments
Labels
website redesign Issue/PR part of the Node.js Website Redesign

Comments

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Sep 29, 2023

Create a NavItem component using the new figma design (direct link to Nav) and here is Footer.

This component is a link with additional styling for focus states, and an indicator if the href is an external link. This one component will be used for both the Navbar (green accents) and the Footer (grey accents) in future issues.

Read more about the Node.js Website redesign


Before You Start...


Details

image

image

Not sure where to start breaking down the figma? Read this short guide

  • Create a new directory called NavItem within the sections directory that contains all the new code. sections may not exist yet
  • Use the new tailwind color and typography system to assign properties. For example, the NavItem active states uses Green/600 per the figma.
  • Add a storybook story file components/sections/NavItem/index.stories.tsx which exercises each of the component's states.
  • Use intelligent detection of the href host compared to the current host to determine if the link is external. If it is, render arrow-up-right icon from the hero icons dependency. This only applies for type === nav

Suggested props include:

  • label (string): Learn in the figma
  • href (typeof next/link)
  • type (enum, nav | footer)

There are 8 Navbar states to capture within styles and stories:

  • Light, internal link
  • Light, internal link, active (focused or hovered)
  • Light, external link
  • Light, external link, active (focused or hovered)
  • Dark, internal link
  • Dark, internal link, active (focused or hovered)
  • Dark, external link
  • Dark, external link, active (focused or hovered)

There are 4 footer states to capture within styles and stories:

  • Light
  • Light, active (focused or hovered)
  • Dark
  • Dark, active (focused or hovered)
@bmuenzenmeyer bmuenzenmeyer added the website redesign Issue/PR part of the Node.js Website Redesign label Sep 29, 2023
@bmuenzenmeyer bmuenzenmeyer changed the title Create NavbarItem Component Create NavbarItem and FooterItem Components Sep 29, 2023
@bmuenzenmeyer bmuenzenmeyer changed the title Create NavbarItem and FooterItem Components Create NavItem Component Sep 29, 2023
@ovflowd ovflowd added help wanted good first issue Issues for newcomers labels Sep 29, 2023
@shaikahmadnawaz
Copy link
Contributor

Can I work on this issue?

@bmuenzenmeyer
Copy link
Collaborator Author

yes, go for it! thanks @shaikahmadnawaz

@shaikahmadnawaz
Copy link
Contributor

yes, go for it! thanks @shaikahmadnawaz

Thank you @bmuenzenmeyer

@shaikahmadnawaz

This comment was marked as off-topic.

@ovflowd

This comment was marked as off-topic.

@shaikahmadnawaz
Copy link
Contributor

Yes I did, how can I run without installing dependencies 😗

@ovflowd
Copy link
Member

ovflowd commented Sep 29, 2023

Yes I did, how can I run without installing dependencies 😗

It's a common question to do. I would recommend you to open an issue so that we don't pollute this one. I can only tell you that the whole process works fine on Linux, macOS and Windows because we have CI for that.

Open a new issue reporting this problem and don't forget to attach your Node.js version and NPM version.

@shaikahmadnawaz
Copy link
Contributor

Yes I did, how can I run without installing dependencies 😗

It's a common question to do. I would recommend you to open an issue so that we don't pollute this one. I can only tell you that the whole process works fine on Linux, macOS and Windows because we have CI for that.

Open a new issue reporting this problem and don't forget to attach your Node.js version and NPM version.

Okay 👍

@ovflowd ovflowd removed help wanted good first issue Issues for newcomers labels Sep 29, 2023
@shaikahmadnawaz
Copy link
Contributor

@ovflowd, check the issue once #5921, I mentioned the problem I am facing while running it locally.

Issue #5921

@shaikahmadnawaz
Copy link
Contributor

#5921 issues solved, now I am good to go. 😊

@fa-901
Copy link
Contributor

fa-901 commented Oct 7, 2023

@ovflowd I noticed this issue was moved back to Ready status and no one was assigned to it. So I went ahead and made a PR

@DhairyaMajmudar DhairyaMajmudar mentioned this issue Oct 7, 2023
5 tasks
@AugustinMauroy AugustinMauroy linked a pull request Oct 8, 2023 that will close this issue
5 tasks
@ovflowd ovflowd closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website redesign Issue/PR part of the Node.js Website Redesign
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants