Adding NavItem #5973
Adding NavItem #5973
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@ovflowd Bhaiya as instructed I opened a pull request for this issue . Even though I tried my level best to do it on first but failed by few hours 🙏 . I would be blessed if you accept my PR and it will be an honor for me to contribute in the codebase of NodeJS website |
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Should we accept idea IDE in this pr ?
There was a problem hiding this comment.
No. All these files should be deleted.
| @@ -0,0 +1,39 @@ | |||
| .navItem { | |||
| @apply inline-flex items-center gap-2 rounded px-3 py-2; | |||
There was a problem hiding this comment.
Remember to reread the contribution guideline 😄
Example of how it's should write
|
If this is not the case, please feel free to justify your reasoning, and I apologize for any inconvenience. |
Sir to be honest I have created the components by my own with the help of JavaScript in a dummy folder since I lack knowledge of Typescript I referenced the PR and took code from it I am really very sorry for the same I hope you understand and forgive me 🙏🏻 |
Hey there. I understand that on your urge to make a contribution, and due to lack of knowledge you thought the best approach here was to go to another PR and copy their codebase. But that is never the solution. It's a non-ethical approach. Giving credits or not. Both of you want to make a meaningful contribution, and I (we) appreciate that, but there are ways of doing this without putting someone's effort in detriment. If you lack knowledge or are a novice, we're here to help. PRs can be opened as a draft, and you can always ask for support, guidance or instructions. There's nothing really to forgive as I doubt you had ill intents; But sadly I cannot allow this PR, hence it will not get merged. I hope you find this opportunity to find another issue soon (We're opening more issues soon) and be able to still contribute. I appreciate your energy and gesture, but keep in mind that this is not a competition about who merges first or et cetera; Have a good one! |
Description
Issue Solved : Create NavItem Component #5911
created NavItem component wtih help of typescript and tailwind css whole design is copied from the figma file provided by admin
Validation
Dark Mode
Light Mode
Also in the active stage the button gets converted in green color as specified in the figma file.
Related Issues
Create NavItem Component #5911
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.