Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express answers to survey #230

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Conversation

wesleytodd
Copy link
Member

I know it has been slow in getting to these (which is why we need help), but here they are. Let me know if there are any areas we can answer better.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eomm
Copy link
Member

Eomm commented Jul 18, 2019

Could we try to define some tasks or we will do it in a separate PR?

@@ -0,0 +1,60 @@
# Express answers to the survey

## What are the biggest problems your package need to face?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## What are the biggest problems your package need to face?
## What are the biggest problems your package faces, past present or future?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is, the grammar is a bit odd.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This the the phrasing presented in the survey questions. Maybe after we merge this, @Qix-, you could contribute a PR to fix it in all three places? The survey, this doc, and the answers from MQTT.js?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleytodd that makes sense to me.

@mhdawson
Copy link
Member

@Eomm, ideally we should document the current 'top 10' in an issue (either here or in the express repo) and have at least a pointer from this repo so that we can actively track what we should encouraging people to help out with.

@wesleytodd
Copy link
Member Author

When I get home from the office today I will extract the list I have and post it as an issue in the Express discussions repo. I will post a link here for reference and we can pull out tasks from there.

@mhdawson
Copy link
Member

Unless there are objections I'll plan to land this in the next day or two.

@Eomm Eomm merged commit 9fb7440 into nodejs:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants