Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency management: wording improvements #425

Merged
merged 2 commits into from
Jan 6, 2021
Merged

Dependency management: wording improvements #425

merged 2 commits into from
Jan 6, 2021

Conversation

dominykas
Copy link
Member

@dominykas dominykas commented Oct 26, 2020

It seems I deleted my fork of this repo at some point, so #302 now does not have a "source". I have pushed the dep-mgmt branch directly into here (it is exactly where #302 is) and then I intend to make the necessary text changes in here.

Not sure how to merge this best (or if it even matters), but I guess we can either merge #302, then this, or we can close #302 and retarget this against main.

I'll keep this draft in the meantime.

#302 is now merged; Also moving this out of drafts folder.

@dominykas dominykas mentioned this pull request Oct 26, 2020
@dominykas dominykas added the package-maintenance-agenda Agenda items for package-maintenance team label Nov 16, 2020
@dominykas dominykas removed the package-maintenance-agenda Agenda items for package-maintenance team label Dec 1, 2020
@dominykas dominykas changed the base branch from dep-mgmt to main December 7, 2020 21:40
@dominykas dominykas marked this pull request as ready for review December 7, 2020 21:40
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominykas dominykas merged commit d16cd20 into main Jan 6, 2021
@dominykas dominykas deleted the dep-mgmt-fix branch January 6, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants