Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use PerformanceResourceTiming #1517

Merged
merged 1 commit into from
Jun 28, 2022
Merged

feat: use PerformanceResourceTiming #1517

merged 1 commit into from
Jun 28, 2022
+52 −2

Conversation

RafaelGSS
Copy link
Member

Fixes: #952

@RafaelGSS RafaelGSS changed the title update(fetch): use PerformanceResourceTiming fetch: use PerformanceResourceTiming Jun 27, 2022
mcollina
mcollina approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

the PR title is incorrect, linting is failing

@RafaelGSS RafaelGSS changed the title fetch: use PerformanceResourceTiming feat: use PerformanceResourceTiming Jun 28, 2022
@ronag ronag merged commit 99e8a6c into nodejs:main Jun 28, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
@RafaelGSS @metcoder95
update(fetch): use PerformanceResourceTiming (nodejs#1517)
b421123
@jimmywarting
Copy link
Contributor

jimmywarting commented Sep 6, 2023 •
edited
Loading

Shouldn't the url/name be a string instead of a URL instance?

@KhafraDev
Copy link
Member

eb24cc8

@theanarkh theanarkh mentioned this pull request Feb 22, 2024
Closed
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@RafaelGSS @crysmags
update(fetch): use PerformanceResourceTiming (nodejs#1517)
057b235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ronag ronag ronag approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mark resource timing
5 participants
@RafaelGSS @mcollina @jimmywarting @KhafraDev @ronag