Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: respect --max-http-header-size Node.js flag #2234

Merged
merged 16 commits into from
Oct 6, 2023
+50 −3
Merged

feat: respect --max-http-header-size Node.js flag #2234

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
331d437
feat: respect Node.js flag
balazsorban44 Aug 31, 2023
26eaf6a
add test
balazsorban44 Aug 31, 2023
a0eb07a
cleaner test
balazsorban44 Sep 1, 2023
f245be8
fix test
balazsorban44 Sep 1, 2023
b222781
update docs
balazsorban44 Sep 1, 2023
9f442d2
revert empty space
balazsorban44 Sep 1, 2023
26d7b42
remove already default value
balazsorban44 Sep 1, 2023
295a461
add
balazsorban44 Sep 2, 2023
cc7388a
don't use `globalThis.fetch` to pass test in Node.js 16
balazsorban44 Sep 2, 2023
417ef09
add test under `test/fetch`
balazsorban44 Sep 5, 2023
fe9a888
Merge main
balazsorban44 Sep 19, 2023
97dea34
Merge branch 'main' into feat/respect-node-max-header-size-flag
balazsorban44 Oct 5, 2023
f8472b9
fix lint
balazsorban44 Oct 5, 2023
772ead8
import from `undici-fetch`
balazsorban44 Oct 5, 2023
b56acb9
use correct paths, use `request` for pure undici test
balazsorban44 Oct 5, 2023
2c9156b
fix Node.js 14 test
balazsorban44 Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test under test/fetch
  • Loading branch information
@balazsorban44
balazsorban44 committed Sep 5, 2023
commit 417ef095ebe0f364fc2905098d430f9213821b2b
24 changes: 24 additions & 0 deletions test/fetch/client-node-max-header-size.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
'use strict'

const { execSync } = require('node:child_process')
const { test } = require('tap')

const command = 'node -e "require(\'.\').fetch(\'https://httpbin.org/get\')"'

test("respect Node.js' --max-http-header-size", async (t) => {

Check failure on line 8 in test/fetch/client-node-max-header-size.js

View workflow job for this annotation

GitHub Actions / lint 

Block must not be padded by blank lines


Check failure on line 10 in test/fetch/client-node-max-header-size.js

View workflow job for this annotation

GitHub Actions / lint 

More than 1 blank line not allowed
t.throws(
() => execSync(`${command} --max-http-header-size=1`),
/UND_ERR_HEADERS_OVERFLOW/,
'max-http-header-size=1 should throw'
)

t.doesNotThrow(
() => execSync(command),
/UND_ERR_HEADERS_OVERFLOW/,
'default max-http-header-size should not throw'
)

t.end()
})
Loading