Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stuck when using http2 POST Buffer #2336

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Fix stuck when using http2 POST Buffer #2336

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecdf5ce
fix: 🐛 call stream.end when POST Buffer
binsee Oct 11, 2023
fdef1fc
test: ✅ add test POST Buffer for http2
binsee Oct 11, 2023
338ee42
test: ✅ remove debug log
binsee Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: 🐛 call stream.end when POST Buffer
  • Loading branch information
@binsee
binsee committed Oct 11, 2023
commit ecdf5cea48ef6fc4abc11fbe31ac984d3ca991c3
1 change: 1 addition & 0 deletions lib/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1862,6 +1862,7 @@ function writeH2 (client, session, request) {
stream.cork()
stream.write(body)
stream.uncork()
stream.end()
request.onBodySent(body)
request.onRequestSent()
} else if (util.isBlobLike(body)) {
Expand Down