Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: optimize consumeEnd #2510

Merged
merged 12 commits into from
Dec 9, 2023
Merged

perf: optimize consumeEnd #2510

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
076bb22
perf: optimize consumeEnd
tsctx Dec 7, 2023
3efff25
fixup
tsctx Dec 7, 2023
6c0f5ca
suggestion change
tsctx Dec 7, 2023
bc562af
refactor
tsctx Dec 7, 2023
c748f15
Merge remote-tracking branch 'origin' into perf/optimize-consumeEnd
tsctx Dec 8, 2023
8b07631
refactor
tsctx Dec 8, 2023
fd60bdc
add comment
tsctx Dec 8, 2023
d634b47
avoid switch break statements
tsctx Dec 8, 2023
5d87413
Update lib/api/readable.js
tsctx Dec 8, 2023
be10ea7
Update lib/api/readable.js
tsctx Dec 8, 2023
6a6fc0d
fixup
tsctx Dec 8, 2023
a8be777
fix: json
tsctx Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/api/readable.js 
Co-authored-by: Robert Nagy <ronagy@icloud.com>
  • Loading branch information
@tsctx @ronag
tsctx and ronag authored Dec 8, 2023
commit be10ea7e11538c26ac07286296cd14634fad4188
5 changes: 4 additions & 1 deletion lib/api/readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,10 @@ function consumeStart (consume) {
* @param {number} length
*/
function chunksDecode (chunks, length) {
const buffer = Buffer.concat(chunks, length)
if (chunks.length === 0 || length === 0) {
return ''
}
const buffer = chunks.length === 1 ? chunks[0] : Buffer.concat(chunks, length)
return buffer.utf8Slice(
0,
buffer.length >= 3 &&
Expand Down
Loading