Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement throwOnMaxRedirect option for RedirectHandler #2563

Merged
merged 7 commits into from
Jan 17, 2024
Merged

feat: implement throwOnMaxRedirect option for RedirectHandler #2563

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a47d463
feat: implement throwOnMaxRedirect option for RedirectHandler
Dec 30, 2023
c53d9de
added sidebar for apidocs
Jan 6, 2024
b12f302
added test for redirectionLimitReached type
Jan 6, 2024
6f26967
feat: Add handling for throwOnMaxRedirect flag in RedirectHandler
Jan 7, 2024
32b7ef3
Update RedirectHandler.js
mertcanaltin Jan 10, 2024
183cdfe
fix: added error info & flow with return
Jan 10, 2024
8651ec4
fix: type test repair & lint
Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: Add handling for throwOnMaxRedirect flag in RedirectHandler
  • Loading branch information
Mert Can Altin committed Jan 7, 2024
commit 6f269674d1557324d86ab70e50d4f836df708b37
2 changes: 1 addition & 1 deletion lib/handler/RedirectHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class RedirectHandler {
? null
: parseLocation(statusCode, headers)

if (this.history.length >= this.maxRedirections && !this.redirectionLimitReached) {
if (this.opts.throwOnMaxRedirect && this.history.length >= this.maxRedirections) {
if (this.request) {
this.request.abort()
mertcanaltin marked this conversation as resolved.
Show resolved Hide resolved
}
Expand Down
2 changes: 1 addition & 1 deletion test/redirect-request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ for (const factory of [
try {
const { statusCode, headers, body: bodyStream, context: { history } } = await request(t, server, undefined, `http://${server}/300`, {
mertcanaltin marked this conversation as resolved.
Show resolved Hide resolved
maxRedirections: 2,
redirectionLimitReached: 2
throwOnMaxRedirect: true
})

const body = await bodyStream.text()
Expand Down
Loading