Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some "files" are missing from index.json #23

Closed
TooTallNate opened this issue Oct 1, 2020 · 3 comments
Closed

Some "files" are missing from index.json #23

TooTallNate opened this issue Oct 1, 2020 · 3 comments

Comments

@TooTallNate
Copy link

TooTallNate commented Oct 1, 2020

For example, v14.13.0 release directory contains:

../
SHASUMS256.txt                                     29-Sep-2020 21:53                1032
node-v14.13.0-headers.tar.gz                       29-Sep-2020 20:13              588193
node-v14.13.0-headers.tar.xz                       29-Sep-2020 20:13              388700
node-v14.13.0-linux-armv6l.tar.gz                  29-Sep-2020 21:12            32163642
node-v14.13.0-linux-armv6l.tar.xz                  29-Sep-2020 21:13            19044096
node-v14.13.0-linux-x64-musl.tar.gz                29-Sep-2020 20:37            34585714
node-v14.13.0-linux-x64-musl.tar.xz                29-Sep-2020 20:38            22225728
node-v14.13.0-linux-x64-pointer-compression.tar.gz 29-Sep-2020 21:32            34020984
node-v14.13.0-linux-x64-pointer-compression.tar.xz 29-Sep-2020 21:33            21645084
node-v14.13.0-linux-x64-usdt.tar.gz                29-Sep-2020 21:52            33864304
node-v14.13.0-linux-x64-usdt.tar.xz                29-Sep-2020 21:53            21560604

So I would expect the index.json file to have a "files" array matching:

["headers", "linux-armv6l", "linux-x64-musl", "linux-x64-pointer-compression", "linux-x64-usdt"]

However, it only contains "headers" and "linux-armv6l" for some reason:

  {
    "version": "v14.13.0",
    "date": "2020-09-29",
    "files": [
      "headers",
      "linux-armv6l"
    ],
    "npm": "6.14.8",
    "v8": "8.4.371.19",
    "uv": "1.40.0",
    "zlib": "1.2.11",
    "openssl": "1.1.1g",
    "modules": "83",
    "lts": false,
    "security": false
  }
@richardlau
Copy link
Member

I think it's because the "missing" files were never official releases so aren't known to the indexer: https://github.com/nodejs/nodejs-dist-indexer/blob/a3a6653a1135d4824a370fb56b510f4bbf3ce4a4/transform-filename.js#L2-L36

@rvagg
Copy link
Member

rvagg commented Oct 2, 2020

proposed fix @ nodejs/nodejs-dist-indexer#13

rvagg added a commit to nodejs/nodejs-dist-indexer that referenced this issue Oct 5, 2020
rvagg added a commit to nodejs/nodejs-dist-indexer that referenced this issue Oct 5, 2020
rvagg added a commit to nodejs/nodejs-dist-indexer that referenced this issue Oct 5, 2020
rvagg added a commit to nodejs/nodejs-dist-indexer that referenced this issue Oct 5, 2020
rvagg added a commit to nodejs/nodejs-dist-indexer that referenced this issue Oct 14, 2020
@rvagg
Copy link
Member

rvagg commented Oct 14, 2020

took a bit but it's a new dist-indexer is published and is working now

{"version":"v14.13.1","date":"2020-10-07","files":["headers","linux-armv6l","linux-x64-musl","linux-x64-pointer-compression","linux-x64-usdt","win-arm64-7z","win-arm64-zip"],"npm":"6.14.8","v8":"8.4.371.19","uv":"1.40.0","zlib":"1.2.11","openssl":"1.1.1g","modules":"83","lts":false,"security":false},

https://unofficial-builds.nodejs.org/download/release/index.json
https://unofficial-builds.nodejs.org/download/release/index.tab

@rvagg rvagg closed this as completed Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants