Fix crashing on loading fragment when activity is destroyed

noelbautista91 · Dec 3, 2016 · 679a4c1 · 679a4c1
1 parent c8d780d
commit 679a4c1
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 34 deletions.
diff --git a/app/src/main/java/com/nbau21/animatedvectorsample/fragments/LoadingScreenFragment.java b/app/src/main/java/com/nbau21/animatedvectorsample/fragments/LoadingScreenFragment.java
@@ -14,12 +14,13 @@
 
 import com.nbau21.animatedvectorsample.R;
 
+import java.lang.ref.WeakReference;
+
 public class LoadingScreenFragment extends Fragment {
 
-    int count;
     ImageView ivLoading;
     TextView tvLoading;
-    Button btnRestart;
+    DummyLoadingTask loadingTask;
 
     public LoadingScreenFragment() {
     }
@@ -33,20 +34,34 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container,
                              Bundle savedInstanceState) {
         View view = inflater.inflate(R.layout.fragment_loading_screen, container, false);
         ivLoading = (ImageView) view.findViewById(R.id.iv_loading);
-        btnRestart = (Button) view.findViewById(R.id.btn_restart);
         tvLoading = (TextView) view.findViewById(R.id.tv_loading);
-
-        btnRestart.setOnClickListener(new View.OnClickListener() {
-            @Override
-            public void onClick(View view) {
-                new DummyLoadingTask().execute(3);
-            }
-        });
-        new DummyLoadingTask().execute(5);
+        loadingTask = new DummyLoadingTask(view);
+        loadingTask.execute(5);
         return view;
     }
 
-    class DummyLoadingTask extends AsyncTask<Integer, Integer, String> {
+    @Override
+    public void onDestroy() {
+        loadingTask.cancel(true);
+        super.onDestroy();
+    }
+
+    static class DummyLoadingTask extends AsyncTask<Integer, Integer, String> {
+
+        int count;
+        ImageView ivLoading;
+        TextView tvLoading;
+
+        WeakReference<View> weakView;
+        View referencedView;
+
+        DummyLoadingTask(View view) {
+            weakView = new WeakReference<>(view);
+            referencedView = weakView.get();
+
+            ivLoading = (ImageView) referencedView.findViewById(R.id.iv_loading);
+            tvLoading = (TextView) referencedView.findViewById(R.id.tv_loading);
+        }
 
         @Override
         protected String doInBackground(Integer... params) {
@@ -63,23 +78,23 @@ protected String doInBackground(Integer... params) {
 
         @Override
         protected void onPostExecute(String result) {
+            if (referencedView == null) {
+
+            }
+
             count = 0;
             tvLoading.setText("Finished!");
-            ivLoading.setImageDrawable(getResources().getDrawable(R.drawable.animated_loading_final, null));
+            ivLoading.setImageDrawable(referencedView.getContext().getDrawable(R.drawable.animated_loading_final));
             ((Animatable) ivLoading.getDrawable()).start();
-            btnRestart.setVisibility(View.VISIBLE);
-
-            for (Drawable drawable : btnRestart.getCompoundDrawables()) {
-                if (drawable instanceof Animatable) {
-                    ((Animatable) drawable).start();
-                }
-            }
         }
 
         @Override
         protected void onPreExecute() {
-            ivLoading.setImageDrawable(getResources().getDrawable(R.drawable.animated_loading, null));
-            btnRestart.setVisibility(View.INVISIBLE);
+            if (referencedView == null) {
+
+            }
+
+            ivLoading.setImageDrawable(referencedView.getContext().getDrawable(R.drawable.animated_loading));
             ((Animatable) ivLoading.getDrawable()).start();
             tvLoading.setText("Loading..");
         }
@@ -89,6 +104,4 @@ protected void onProgressUpdate(Integer... values) {
             tvLoading.setText("Loading.. " + count + " seconds passed!");
         }
     }
-
-
 }
diff --git a/app/src/main/res/layout/fragment_loading_screen.xml b/app/src/main/res/layout/fragment_loading_screen.xml
@@ -21,14 +21,4 @@
         android:layout_below="@+id/iv_loading"
         android:layout_centerHorizontal="true" />
 
-    <Button
-        android:layout_below="@+id/tv_loading"
-        android:drawableBottom="@drawable/animated_cat"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:layout_centerHorizontal="true"
-        android:text="Restart animation!"
-        android:id="@+id/btn_restart"
-        android:visibility="invisible"/>
-
 </RelativeLayout>