Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate more ESLint rules #789

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Activate more ESLint rules #789

merged 5 commits into from
Sep 26, 2024

Conversation

weeman1337
Copy link
Contributor

Activate ESLint rules, that we skipped on migration: https://github.com/nordeck/matrix-widget-toolkit/pull/768/files#diff-9601a8f6c734c2001be34a2361f76946d19a39a709b5e8c624a2a5a0aade05f2

For PropsWithChildren the solution was to drop the generic type. It defaults to unknown.

Additionally there is now an extra type for „empty objects“.

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: 42ea623

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@weeman1337 weeman1337 changed the title Nic/fix/neo 790 eslint rules Activate more ESLint rules Sep 25, 2024
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
@weeman1337 weeman1337 marked this pull request as ready for review September 25, 2024 12:02
@weeman1337 weeman1337 requested a review from a team as a code owner September 25, 2024 12:02
Copy link
Contributor

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeset, since the API reports got updated?

@weeman1337
Copy link
Contributor Author

changeset, since the API reports got updated?

🤷 before you were able to pass anything. Now you can do the same. We can add a patch note about that. What do you think?

@HarHarLinks
Copy link
Contributor

If as a toolkit consumer I don't have to change anything then I guess we don't need anything.

HarHarLinks
HarHarLinks previously approved these changes Sep 26, 2024
@weeman1337 weeman1337 merged commit e10672b into main Sep 26, 2024
4 checks passed
@weeman1337 weeman1337 deleted the nic/fix/NEO-790-eslint-rules branch September 26, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants