-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate more ESLint rules #789
Conversation
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
|
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
05dc8d6
to
b1b4159
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changeset, since the API reports got updated?
🤷 before you were able to pass anything. Now you can do the same. We can add a patch note about that. What do you think? |
If as a toolkit consumer I don't have to change anything then I guess we don't need anything. |
Activate ESLint rules, that we skipped on migration: https://github.com/nordeck/matrix-widget-toolkit/pull/768/files#diff-9601a8f6c734c2001be34a2361f76946d19a39a709b5e8c624a2a5a0aade05f2
For
PropsWithChildren
the solution was to drop the generic type. It defaults tounknown
.Additionally there is now an extra type for „empty objects“.
✔️ Checklist
Signed-off-by
line in the message (more info).