Improve Matrix Content (mxc://) URIs in tests #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmad Kadri <ahmad.kadri@nordeck.net>
|
weeman1337
requested changes
Oct 8, 2024
| />, | ||
| ); | ||
|
|
||
| await expect( | ||
| screen.findByRole('presentation', { hidden: true }), | ||
| ).resolves.toHaveAttribute( | ||
| 'src', | ||
| expect.stringMatching(/\/_matrix\/media\/r0\/thumbnail\/alice/i), | ||
| expect.stringMatching(/\/_matrix\/media\/r0\/thumbnail\/.*\/imageAlice/i), |
There was a problem hiding this comment.
This should also contain the server name https://spec.matrix.org/v1.12/client-server-api/#get_matrixclientv1mediathumbnailservernamemediaid
Signed-off-by: Ahmad Kadri <ahmad.kadri@nordeck.net>
HarHarLinks
reviewed
Oct 8, 2024
mgcm
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✔️ Checklist
Signed-off-byline in the message (more info).