Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to reflect use of reference types over oci index #80

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

SteveLasker
Copy link
Contributor

Signed-off-by: Steve Lasker stevenlasker@hotmail.com

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that we want to completely remove all mention of oci-index since there's probably a scenario to capture where someone pulls the top level index and wants to verify the resulting image before running it. We may still satisfy that use case by verifying the nested image, but users may want some assurance that Notary v2 will work if they build and/or deploy multi-platform images.

scenarios.md Outdated
* In addition to the `image`, `SBoM` and `src` artifacts, the build system produces an [OCI Index][oci-index] that encompassed the three artifacts.
* Each of the artifacts, and the encompassing `index` are signed with the Notary v2 wabbit-networks key.
2. The Wabbit Networks net-monitor index and its signed contents are pushed to a public OCI compliant registry.
* In addition to the `image` the `SBoM` and `src` artifacts are created as reference types to the image, creating a graph of artifacts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion, I'd just remove the "image" mention here.

Suggested change
* In addition to the `image` the `SBoM` and `src` artifacts are created as reference types to the image, creating a graph of artifacts.
* The `SBoM` and `src` artifacts are created as reference types to the image, creating a graph of artifacts.

@SteveLasker
Copy link
Contributor Author

I don't know that we want to completely remove all mention of oci-index

Yeah, good point that we do support any manifest, including signing a multi-arch index. This is really just an update to reflect the learnings and pivot from constantly updating an index everytime a new signature is added, to using reference types to represent a true graph.

I think we can track the multi-arch question separately from this high-level overview.

Signed-off-by: Steve Lasker <stevenlasker@hotmail.com>
@sudo-bmitch
Copy link
Contributor

I think we can track the multi-arch question separately from this high-level overview.

Agreed. I think have a PR that needs updating to update that covers this.

LGTM

@SteveLasker SteveLasker merged commit ea93252 into notaryproject:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants